* net/wireless/chan.c: prohibited_flags wrongly set
@ 2014-05-01 8:26 Arend van Spriel
2014-05-01 20:20 ` Janusz Dziedzic
[not found] ` <CABPxzYJxWtKtJNDVcxA2tt6jFYDQvJ7hpFbwLQ4JHB0CmGihMw@mail.gmail.com>
0 siblings, 2 replies; 3+ messages in thread
From: Arend van Spriel @ 2014-05-01 8:26 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless@vger.kernel.org
Hi Johannes,
I was debugging issue with hostapd failing on setting channel when I
came across this piece of code in chan.c:545:cfg80211_chandef_usable():
if (width > 20)
prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
/* 5 and 10 MHz are only defined for the OFDM PHY */
if (width < 20)
prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
I suspect the first if statement to be wrong, but what should it be?
Regards,
Arend
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net/wireless/chan.c: prohibited_flags wrongly set
2014-05-01 8:26 net/wireless/chan.c: prohibited_flags wrongly set Arend van Spriel
@ 2014-05-01 20:20 ` Janusz Dziedzic
[not found] ` <CABPxzYJxWtKtJNDVcxA2tt6jFYDQvJ7hpFbwLQ4JHB0CmGihMw@mail.gmail.com>
1 sibling, 0 replies; 3+ messages in thread
From: Janusz Dziedzic @ 2014-05-01 20:20 UTC (permalink / raw)
To: Arend van Spriel; +Cc: Johannes Berg, linux-wireless@vger.kernel.org
2014-05-01 10:26 GMT+02:00 Arend van Spriel <arend@broadcom.com>:
> Hi Johannes,
>
> I was debugging issue with hostapd failing on setting channel when I came
> across this piece of code in chan.c:545:cfg80211_chandef_usable():
>
> if (width > 20)
> prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
>
> /* 5 and 10 MHz are only defined for the OFDM PHY */
> if (width < 20)
> prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
>
> I suspect the first if statement to be wrong, but what should it be?
>
width > 20 - HT40, VHT80 ... - 80211n/80211ac using OFDM - so NO_OFDM
seems to be prohibited.
BR
Janusz
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <CABPxzYJxWtKtJNDVcxA2tt6jFYDQvJ7hpFbwLQ4JHB0CmGihMw@mail.gmail.com>]
* Re: net/wireless/chan.c: prohibited_flags wrongly set
[not found] ` <CABPxzYJxWtKtJNDVcxA2tt6jFYDQvJ7hpFbwLQ4JHB0CmGihMw@mail.gmail.com>
@ 2014-05-02 6:15 ` Krishna Chaitanya
0 siblings, 0 replies; 3+ messages in thread
From: Krishna Chaitanya @ 2014-05-02 6:15 UTC (permalink / raw)
To: Arend van Spriel, linux-wireless
On Thu, May 1, 2014 at 9:36 PM, Krishna Chaitanya
<chaitanya.mgit@gmail.com> wrote:
>
>
> On May 1, 2014 2:01 PM, "Arend van Spriel" <arend@broadcom.com> wrote:
> >
> > Hi Johannes,
> >
> > I was debugging issue with hostapd failing on setting channel when I came across this piece of code in chan.c:545:cfg80211_chandef_usable():
> >
> > if (width > 20)
> > prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
> >
> > /* 5 and 10 MHz are only defined for the OFDM PHY */
> > if (width < 20)
> > prohibited_flags |= IEEE80211_CHAN_NO_OFDM;
> >
> > I suspect the first if statement to be wrong, but what should it be?
>
> Looks ok to me. Basically it says that only 20MHz has a possibility of both OFDM and DSSS.
Adding the list.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-02 6:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-01 8:26 net/wireless/chan.c: prohibited_flags wrongly set Arend van Spriel
2014-05-01 20:20 ` Janusz Dziedzic
[not found] ` <CABPxzYJxWtKtJNDVcxA2tt6jFYDQvJ7hpFbwLQ4JHB0CmGihMw@mail.gmail.com>
2014-05-02 6:15 ` Krishna Chaitanya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.