Re: [Qemu-devel] [PATCH v10 4/4] qapi: Add a primitive to include other files from a QAPI schema file

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On 04/30/2014 01:09 PM, Lluís Vilanova wrote:
> The primitive uses JSON syntax, and include paths are relative to the file using the directive:
> 
>   { 'include': 'path/to/file.json' }
> 
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---

> +++ b/tests/qapi-schema/include-after-err.json
> @@ -0,0 +1,2 @@
> +{ 'include': 'include-simple-sub.json' }
> +{ 'command' 'missing-colon' }

In v9, Markus pointed out that 'include-after-err' is the wrong name for
this test - you are testing that an error after include is detected
correctly, and not the behavior of an error after an include.

It's not a showstopper (I could live with v10 going into the tree), so:

Reviewed-by: Eric Blake <eblake@redhat.com>

But if you want to spin a v11, then rename the related files and the
Makefile rules to run the new name.  As a rename is trivially testable
by 'make check' still passing, then if that's the only change you make,
I'm still okay if you keep my R-b in your v11 message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]