Re: [Qemu-devel] [PATCH v10 3/4] qapi: Use an explicit input file

["Lluís Vilanova" <vilanova@ac.upc.edu>]

Eric Blake writes:

> On 04/30/2014 01:09 PM, Lluís Vilanova wrote:
>> Use an explicit input file on the command-line instead of reading from standard
>> input.
>> 
>> It also outputs the proper file name when there's an error.
>> 
>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> Reviewed-by: Eric Blake <eblake@redhat.com>

> Technically, you made a non-trivial change (use of perl to sanitize
> SRC_PATH) in response to a comment that did not come from my review. You
> properly called it out in the cover letter, so I looked at this patch
> again; but in general, when making non-trivial changes, it's best to
> remove the Reviewed-by to make sure that earlier reviewers notice that
> they need to look again, and that they are still happy with the changes.

> Fortunately, in this case, your changes still look okay, so I'm okay
> with leaving my Reviewed-by on this version of the patch.

>> "  TEST  $*.out")
>> @diff -q $(SRC_PATH)/$*.out $*.test.out
>> -	@diff -q $(SRC_PATH)/$*.err $*.test.err
>> +	@# Sanitize error messages (make them independent of build directory)
>> +	@perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q $(SRC_PATH)/$*.err -
>> @diff -q $(SRC_PATH)/$*.exit $*.test.exit
>> 

Ok. Also note that I did not do the exact change proposed by Markus. I've
removed the '^' from the regular expression, since "tracebacks" in error
messages also contain the file path.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth