From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
patches@linaro.org
Subject: Re: [Qemu-trivial] [PATCH v2] tests/tcg: Fix compilation of test_path
Date: Sat, 03 May 2014 12:39:33 +0400 [thread overview]
Message-ID: <5364AB45.9010106@msgid.tls.msk.ru> (raw)
In-Reply-To: <1398769764-25493-1-git-send-email-peter.maydell@linaro.org>
29.04.2014 15:09, Peter Maydell wrote:
> The test_path binary is (unlike the other test binaries in tests/tcg)
> actually intended to be compiled with the same compiler used to build
> the main QEMU executables. It actually #includes a number of the
> QEMU source files in an attempt to unit-test the util/path.c functions,
> and so if it is not compiled with the same compiler used by configure
> to set CONFIG_ settings then it is liable to fail to build.
> Fix the makefile to build it with the default C compiler rules, not
> CC_I386, and fix the test itself not to include a lot of unnecessary
> trace related source files which cause the build to fail if the trace
> backend is anything other than 'simple'.
Yay, ACK!
Applies to -trivial, thank you!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
patches@linaro.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] tests/tcg: Fix compilation of test_path
Date: Sat, 03 May 2014 12:39:33 +0400 [thread overview]
Message-ID: <5364AB45.9010106@msgid.tls.msk.ru> (raw)
In-Reply-To: <1398769764-25493-1-git-send-email-peter.maydell@linaro.org>
29.04.2014 15:09, Peter Maydell wrote:
> The test_path binary is (unlike the other test binaries in tests/tcg)
> actually intended to be compiled with the same compiler used to build
> the main QEMU executables. It actually #includes a number of the
> QEMU source files in an attempt to unit-test the util/path.c functions,
> and so if it is not compiled with the same compiler used by configure
> to set CONFIG_ settings then it is liable to fail to build.
> Fix the makefile to build it with the default C compiler rules, not
> CC_I386, and fix the test itself not to include a lot of unnecessary
> trace related source files which cause the build to fail if the trace
> backend is anything other than 'simple'.
Yay, ACK!
Applies to -trivial, thank you!
/mjt
next prev parent reply other threads:[~2014-05-03 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 11:09 [Qemu-trivial] [PATCH v2] tests/tcg: Fix compilation of test_path Peter Maydell
2014-05-03 8:39 ` Michael Tokarev [this message]
2014-05-03 8:39 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5364AB45.9010106@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.