From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>,
"Hani Benhabiles" <kroosec@gmail.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] qmp: Report path ambiguity error.
Date: Mon, 05 May 2014 13:31:50 +0400 [thread overview]
Message-ID: <53675A86.1080505@msgid.tls.msk.ru> (raw)
In-Reply-To: <53675935.7010105@suse.de>
05.05.2014 13:26, Andreas Färber пишет:
>> 03.05.2014 12:38, Michael Tokarev wrote:
>>> + error_set(errp,
>>> + ambiguous ? "Path '%s' is ambiguous" : QERR_DEVICE_NOT_FOUND,
>>> + path);
>> I've applied this version.
>
> Please undo. error_set() unlike error_setg() expects an ErrorClass
> argument before the string. QERR_* macro contains *two* comma-separated
> values, so it is on top filling in the device-not-found message as path
> in the ambiguous case.
Heh, I havent tried to compile it yet ;) Ofcourse I'd find this out before
sending the pull request. Actually this is a classic ENOCOFFEE, twice.
I'll fix this for real. This makes way too many iterations.
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>,
"Hani Benhabiles" <kroosec@gmail.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qmp: Report path ambiguity error.
Date: Mon, 05 May 2014 13:31:50 +0400 [thread overview]
Message-ID: <53675A86.1080505@msgid.tls.msk.ru> (raw)
In-Reply-To: <53675935.7010105@suse.de>
05.05.2014 13:26, Andreas Färber пишет:
>> 03.05.2014 12:38, Michael Tokarev wrote:
>>> + error_set(errp,
>>> + ambiguous ? "Path '%s' is ambiguous" : QERR_DEVICE_NOT_FOUND,
>>> + path);
>> I've applied this version.
>
> Please undo. error_set() unlike error_setg() expects an ErrorClass
> argument before the string. QERR_* macro contains *two* comma-separated
> values, so it is on top filling in the device-not-found message as path
> in the ambiguous case.
Heh, I havent tried to compile it yet ;) Ofcourse I'd find this out before
sending the pull request. Actually this is a classic ENOCOFFEE, twice.
I'll fix this for real. This makes way too many iterations.
/mjt
next prev parent reply other threads:[~2014-05-05 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 22:46 [Qemu-trivial] [PATCH] qmp: Report path ambiguity error Hani Benhabiles
2014-05-03 8:38 ` Michael Tokarev
2014-05-03 8:38 ` [Qemu-devel] " Michael Tokarev
2014-05-05 9:12 ` Michael Tokarev
2014-05-05 9:12 ` [Qemu-devel] " Michael Tokarev
2014-05-05 9:26 ` Andreas Färber
2014-05-05 9:26 ` [Qemu-devel] " Andreas Färber
2014-05-05 9:31 ` Michael Tokarev [this message]
2014-05-05 9:31 ` Michael Tokarev
2014-05-05 9:37 ` [Qemu-trivial] [Qemu-devel] " Andreas Färber
2014-05-05 9:37 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53675A86.1080505@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=afaerber@suse.de \
--cc=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.