From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: BOOK3S: PR: Fix WARN_ON with debug options on
Date: Mon, 05 May 2014 11:29:49 +0000 [thread overview]
Message-ID: <5367762D.4030503@suse.de> (raw)
In-Reply-To: <1399224368-22122-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/04/2014 07:26 PM, Aneesh Kumar K.V wrote:
> With debug option "sleep inside atomic section checking" enabled we get
> the below WARN_ON during a PR KVM boot. This is because upstream now
> have PREEMPT_COUNT enabled even if we have preempt disabled. Fix the
> warning by adding preempt_disable/enable around floating point and altivec
> enable.
>
> WARNING: at arch/powerpc/kernel/process.c:156
> Modules linked in: kvm_pr kvm
> CPU: 1 PID: 3990 Comm: qemu-system-ppc Tainted: G W 3.15.0-rc1+ #4
> task: c0000000eb85b3a0 ti: c0000000ec59c000 task.ti: c0000000ec59c000
> NIP: c000000000015c84 LR: d000000003334644 CTR: c000000000015c00
> REGS: c0000000ec59f140 TRAP: 0700 Tainted: G W (3.15.0-rc1+)
> MSR: 8000000000029032 <SF,EE,ME,IR,DR,RI> CR: 42000024 XER: 20000000
> CFAR: c000000000015c24 SOFTE: 1
> GPR00: d000000003334644 c0000000ec59f3c0 c000000000e2fa40 c0000000e2f80000
> GPR04: 0000000000000800 0000000000002000 0000000000000001 8000000000000000
> GPR08: 0000000000000001 0000000000000001 0000000000002000 c000000000015c00
> GPR12: d00000000333da18 c00000000fb80900 0000000000000000 0000000000000000
> GPR16: 0000000000000000 0000000000000000 0000000000000000 00003fffce4e0fa1
> GPR20: 0000000000000010 0000000000000001 0000000000000002 00000000100b9a38
> GPR24: 0000000000000002 0000000000000000 0000000000000000 0000000000000013
> GPR28: 0000000000000000 c0000000eb85b3a0 0000000000002000 c0000000e2f80000
> NIP [c000000000015c84] .enable_kernel_fp+0x84/0x90
> LR [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> Call Trace:
> [c0000000ec59f3c0] [0000000000000010] 0x10 (unreliable)
> [c0000000ec59f430] [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> [c0000000ec59f4c0] [d00000000324b380] .kvmppc_set_msr+0x30/0x50 [kvm]
> [c0000000ec59f530] [d000000003337cac] .kvmppc_core_emulate_op_pr+0x16c/0x5e0 [kvm_pr]
> [c0000000ec59f5f0] [d00000000324a944] .kvmppc_emulate_instruction+0x284/0xa80 [kvm]
> [c0000000ec59f6c0] [d000000003336888] .kvmppc_handle_exit_pr+0x488/0xb70 [kvm_pr]
> [c0000000ec59f790] [d000000003338d34] kvm_start_lightweight+0xcc/0xdc [kvm_pr]
> [c0000000ec59f960] [d000000003336288] .kvmppc_vcpu_run_pr+0xc8/0x190 [kvm_pr]
> [c0000000ec59f9f0] [d00000000324c880] .kvmppc_vcpu_run+0x30/0x50 [kvm]
> [c0000000ec59fa60] [d000000003249e74] .kvm_arch_vcpu_ioctl_run+0x54/0x1b0 [kvm]
> [c0000000ec59faf0] [d000000003244948] .kvm_vcpu_ioctl+0x478/0x760 [kvm]
> [c0000000ec59fcb0] [c000000000224e34] .do_vfs_ioctl+0x4d4/0x790
> [c0000000ec59fd90] [c000000000225148] .SyS_ioctl+0x58/0xb0
> [c0000000ec59fe30] [c00000000000a1e4] syscall_exit+0x0/0x98
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Thanks, applied to kvm-ppc-queue.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: BOOK3S: PR: Fix WARN_ON with debug options on
Date: Mon, 05 May 2014 13:29:49 +0200 [thread overview]
Message-ID: <5367762D.4030503@suse.de> (raw)
In-Reply-To: <1399224368-22122-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/04/2014 07:26 PM, Aneesh Kumar K.V wrote:
> With debug option "sleep inside atomic section checking" enabled we get
> the below WARN_ON during a PR KVM boot. This is because upstream now
> have PREEMPT_COUNT enabled even if we have preempt disabled. Fix the
> warning by adding preempt_disable/enable around floating point and altivec
> enable.
>
> WARNING: at arch/powerpc/kernel/process.c:156
> Modules linked in: kvm_pr kvm
> CPU: 1 PID: 3990 Comm: qemu-system-ppc Tainted: G W 3.15.0-rc1+ #4
> task: c0000000eb85b3a0 ti: c0000000ec59c000 task.ti: c0000000ec59c000
> NIP: c000000000015c84 LR: d000000003334644 CTR: c000000000015c00
> REGS: c0000000ec59f140 TRAP: 0700 Tainted: G W (3.15.0-rc1+)
> MSR: 8000000000029032 <SF,EE,ME,IR,DR,RI> CR: 42000024 XER: 20000000
> CFAR: c000000000015c24 SOFTE: 1
> GPR00: d000000003334644 c0000000ec59f3c0 c000000000e2fa40 c0000000e2f80000
> GPR04: 0000000000000800 0000000000002000 0000000000000001 8000000000000000
> GPR08: 0000000000000001 0000000000000001 0000000000002000 c000000000015c00
> GPR12: d00000000333da18 c00000000fb80900 0000000000000000 0000000000000000
> GPR16: 0000000000000000 0000000000000000 0000000000000000 00003fffce4e0fa1
> GPR20: 0000000000000010 0000000000000001 0000000000000002 00000000100b9a38
> GPR24: 0000000000000002 0000000000000000 0000000000000000 0000000000000013
> GPR28: 0000000000000000 c0000000eb85b3a0 0000000000002000 c0000000e2f80000
> NIP [c000000000015c84] .enable_kernel_fp+0x84/0x90
> LR [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> Call Trace:
> [c0000000ec59f3c0] [0000000000000010] 0x10 (unreliable)
> [c0000000ec59f430] [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> [c0000000ec59f4c0] [d00000000324b380] .kvmppc_set_msr+0x30/0x50 [kvm]
> [c0000000ec59f530] [d000000003337cac] .kvmppc_core_emulate_op_pr+0x16c/0x5e0 [kvm_pr]
> [c0000000ec59f5f0] [d00000000324a944] .kvmppc_emulate_instruction+0x284/0xa80 [kvm]
> [c0000000ec59f6c0] [d000000003336888] .kvmppc_handle_exit_pr+0x488/0xb70 [kvm_pr]
> [c0000000ec59f790] [d000000003338d34] kvm_start_lightweight+0xcc/0xdc [kvm_pr]
> [c0000000ec59f960] [d000000003336288] .kvmppc_vcpu_run_pr+0xc8/0x190 [kvm_pr]
> [c0000000ec59f9f0] [d00000000324c880] .kvmppc_vcpu_run+0x30/0x50 [kvm]
> [c0000000ec59fa60] [d000000003249e74] .kvm_arch_vcpu_ioctl_run+0x54/0x1b0 [kvm]
> [c0000000ec59faf0] [d000000003244948] .kvm_vcpu_ioctl+0x478/0x760 [kvm]
> [c0000000ec59fcb0] [c000000000224e34] .do_vfs_ioctl+0x4d4/0x790
> [c0000000ec59fd90] [c000000000225148] .SyS_ioctl+0x58/0xb0
> [c0000000ec59fe30] [c00000000000a1e4] syscall_exit+0x0/0x98
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Thanks, applied to kvm-ppc-queue.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: BOOK3S: PR: Fix WARN_ON with debug options on
Date: Mon, 05 May 2014 13:29:49 +0200 [thread overview]
Message-ID: <5367762D.4030503@suse.de> (raw)
In-Reply-To: <1399224368-22122-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On 05/04/2014 07:26 PM, Aneesh Kumar K.V wrote:
> With debug option "sleep inside atomic section checking" enabled we get
> the below WARN_ON during a PR KVM boot. This is because upstream now
> have PREEMPT_COUNT enabled even if we have preempt disabled. Fix the
> warning by adding preempt_disable/enable around floating point and altivec
> enable.
>
> WARNING: at arch/powerpc/kernel/process.c:156
> Modules linked in: kvm_pr kvm
> CPU: 1 PID: 3990 Comm: qemu-system-ppc Tainted: G W 3.15.0-rc1+ #4
> task: c0000000eb85b3a0 ti: c0000000ec59c000 task.ti: c0000000ec59c000
> NIP: c000000000015c84 LR: d000000003334644 CTR: c000000000015c00
> REGS: c0000000ec59f140 TRAP: 0700 Tainted: G W (3.15.0-rc1+)
> MSR: 8000000000029032 <SF,EE,ME,IR,DR,RI> CR: 42000024 XER: 20000000
> CFAR: c000000000015c24 SOFTE: 1
> GPR00: d000000003334644 c0000000ec59f3c0 c000000000e2fa40 c0000000e2f80000
> GPR04: 0000000000000800 0000000000002000 0000000000000001 8000000000000000
> GPR08: 0000000000000001 0000000000000001 0000000000002000 c000000000015c00
> GPR12: d00000000333da18 c00000000fb80900 0000000000000000 0000000000000000
> GPR16: 0000000000000000 0000000000000000 0000000000000000 00003fffce4e0fa1
> GPR20: 0000000000000010 0000000000000001 0000000000000002 00000000100b9a38
> GPR24: 0000000000000002 0000000000000000 0000000000000000 0000000000000013
> GPR28: 0000000000000000 c0000000eb85b3a0 0000000000002000 c0000000e2f80000
> NIP [c000000000015c84] .enable_kernel_fp+0x84/0x90
> LR [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> Call Trace:
> [c0000000ec59f3c0] [0000000000000010] 0x10 (unreliable)
> [c0000000ec59f430] [d000000003334644] .kvmppc_handle_ext+0x134/0x190 [kvm_pr]
> [c0000000ec59f4c0] [d00000000324b380] .kvmppc_set_msr+0x30/0x50 [kvm]
> [c0000000ec59f530] [d000000003337cac] .kvmppc_core_emulate_op_pr+0x16c/0x5e0 [kvm_pr]
> [c0000000ec59f5f0] [d00000000324a944] .kvmppc_emulate_instruction+0x284/0xa80 [kvm]
> [c0000000ec59f6c0] [d000000003336888] .kvmppc_handle_exit_pr+0x488/0xb70 [kvm_pr]
> [c0000000ec59f790] [d000000003338d34] kvm_start_lightweight+0xcc/0xdc [kvm_pr]
> [c0000000ec59f960] [d000000003336288] .kvmppc_vcpu_run_pr+0xc8/0x190 [kvm_pr]
> [c0000000ec59f9f0] [d00000000324c880] .kvmppc_vcpu_run+0x30/0x50 [kvm]
> [c0000000ec59fa60] [d000000003249e74] .kvm_arch_vcpu_ioctl_run+0x54/0x1b0 [kvm]
> [c0000000ec59faf0] [d000000003244948] .kvm_vcpu_ioctl+0x478/0x760 [kvm]
> [c0000000ec59fcb0] [c000000000224e34] .do_vfs_ioctl+0x4d4/0x790
> [c0000000ec59fd90] [c000000000225148] .SyS_ioctl+0x58/0xb0
> [c0000000ec59fe30] [c00000000000a1e4] syscall_exit+0x0/0x98
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Thanks, applied to kvm-ppc-queue.
Alex
next prev parent reply other threads:[~2014-05-05 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 17:26 [PATCH] KVM: PPC: BOOK3S: PR: Fix WARN_ON with debug options on Aneesh Kumar K.V
2014-05-04 17:38 ` Aneesh Kumar K.V
2014-05-04 17:26 ` Aneesh Kumar K.V
2014-05-05 11:29 ` Alexander Graf [this message]
2014-05-05 11:29 ` Alexander Graf
2014-05-05 11:29 ` Alexander Graf
2014-05-07 5:56 ` Paul Mackerras
2014-05-07 5:56 ` Paul Mackerras
2014-05-07 5:56 ` Paul Mackerras
2014-05-07 7:58 ` Aneesh Kumar K.V
2014-05-07 7:58 ` Aneesh Kumar K.V
2014-05-07 7:58 ` Aneesh Kumar K.V
2014-05-07 11:37 ` Alexander Graf
2014-05-07 11:37 ` Alexander Graf
2014-05-07 11:37 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5367762D.4030503@suse.de \
--to=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.