From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Fam Zheng <famz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] configure: remove bashism
Date: Mon, 05 May 2014 16:10:41 +0200 [thread overview]
Message-ID: <53679BE1.9040401@redhat.com> (raw)
In-Reply-To: <1399030869-23399-1-git-send-email-mjt@msgid.tls.msk.ru>
Il 02/05/2014 13:41, Michael Tokarev ha scritto:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules. This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some
> shells. Get rid of it, use standard redirection instead.
>
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
> if test "$modules" = yes; then
> shacmd_probe="sha1sum sha1 shasum"
> for c in $shacmd_probe; do
> - if which $c &>/dev/null; then
> + if which $c >/dev/null 2>&1; then
> shacmd="$c"
> break
> fi
>
Applied, and Cced qemu-stable too.
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Fam Zheng <famz@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: remove bashism
Date: Mon, 05 May 2014 16:10:41 +0200 [thread overview]
Message-ID: <53679BE1.9040401@redhat.com> (raw)
In-Reply-To: <1399030869-23399-1-git-send-email-mjt@msgid.tls.msk.ru>
Il 02/05/2014 13:41, Michael Tokarev ha scritto:
> Commit e26110cfc67d48 added a check for shacmd to create a hash
> for modules. This check in configure is using bash construct &>
> to redirect both stdout and stderr, whcih does fun things on some
> shells. Get rid of it, use standard redirection instead.
>
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2fbec59..7442790 100755
> --- a/configure
> +++ b/configure
> @@ -2627,7 +2627,7 @@ done
> if test "$modules" = yes; then
> shacmd_probe="sha1sum sha1 shasum"
> for c in $shacmd_probe; do
> - if which $c &>/dev/null; then
> + if which $c >/dev/null 2>&1; then
> shacmd="$c"
> break
> fi
>
Applied, and Cced qemu-stable too.
next prev parent reply other threads:[~2014-05-05 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 11:41 [Qemu-trivial] [PATCH] configure: remove bashism Michael Tokarev
2014-05-02 11:41 ` [Qemu-devel] " Michael Tokarev
2014-05-04 1:39 ` [Qemu-trivial] " Fam Zheng
2014-05-04 1:39 ` [Qemu-devel] " Fam Zheng
2014-05-05 14:10 ` Paolo Bonzini [this message]
2014-05-05 14:10 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53679BE1.9040401@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.