All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@baker-net.org.uk (Adam Baker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/15] ARM: dts: kirkwood: fix mislocated pcie-controller nodes
Date: Mon, 05 May 2014 23:20:28 +0100	[thread overview]
Message-ID: <53680EAC.3090401@baker-net.org.uk> (raw)
In-Reply-To: <1398862602-29595-2-git-send-email-sebastian.hesselbarth@gmail.com>

On 30/04/14 13:56, Sebastian Hesselbarth wrote:
> Commit 54397d85349f
>   ("ARM: kirkwood: Relocate PCIe device tree nodes")
>
> moved the pcie-controller nodes for the Kirkwood SoCs to the mbus
> bus node. For some reason, two boards were not properly converted
> and have their pci-controller nodes still in the ocp bus node.
>
> As the corresponding SoC pcie-controller does not exist anymore,
> it is likely that pcie is broken on those boards since above commit.
> Fix it by moving the pcie related nodes to the correct location.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>


I've tried this patch on NSA320, as expected it doesn't make any 
observable difference as there is nothing connected to the PCIe bus 
(hence not really worth a tested by). It matters more on the NSA310 as 
that uses PCIe for Ethernet.

Regards

Adam Baker

> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
>   arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 18 ++++++++++--------
>   arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi  | 18 ++++++++++--------
>   2 files changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> index 2cb0dc529165..4bf358c28be2 100644
> --- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> +++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> @@ -30,6 +30,16 @@
>   		bootargs = "console=ttyS0,115200n8 earlyprintk";
>   	};
>
> +	mbus {
> +		pcie-controller {
> +			status = "okay";
> +
> +			pcie at 1,0 {
> +				status = "okay";
> +			};
> +		};
> +        };
> +
>   	ocp at f1000000 {
>   		pinctrl at 10000 {
>   			pmx_usb_led: pmx-usb-led {
> @@ -73,14 +83,6 @@
>   		ehci at 50000 {
>   			status = "okay";
>   		};
> -
> -		pcie-controller {
> -			status = "okay";
> -
> -			pcie at 1,0 {
> -				status = "okay";
> -			};
> -		};
>   	};
>
>   	gpio-leds {
> diff --git a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> index 843b8b561e5e..b88810df7ca2 100644
> --- a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> @@ -4,6 +4,16 @@
>   / {
>   	model = "ZyXEL NSA310";
>
> +	mbus {
> +		pcie-controller {
> +			status = "okay";
> +
> +			pcie at 1,0 {
> +				status = "okay";
> +			};
> +		};
> +	};
> +
>   	ocp at f1000000 {
>   		pinctrl: pinctrl at 10000 {
>
> @@ -51,14 +61,6 @@
>   			status = "okay";
>   			nr-ports = <2>;
>   		};
> -
> -		pcie-controller {
> -			status = "okay";
> -
> -			pcie at 1,0 {
> -				status = "okay";
> -			};
> -		};
>   	};
>
>   	gpio_poweroff {
>

WARNING: multiple messages have this Message-ID (diff)
From: Adam Baker <linux@baker-net.org.uk>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@arm.linux.org.uk>,
	Jason Cooper <jason@lakedaemon.net>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/15] ARM: dts: kirkwood: fix mislocated pcie-controller nodes
Date: Mon, 05 May 2014 23:20:28 +0100	[thread overview]
Message-ID: <53680EAC.3090401@baker-net.org.uk> (raw)
In-Reply-To: <1398862602-29595-2-git-send-email-sebastian.hesselbarth@gmail.com>

On 30/04/14 13:56, Sebastian Hesselbarth wrote:
> Commit 54397d85349f
>   ("ARM: kirkwood: Relocate PCIe device tree nodes")
>
> moved the pcie-controller nodes for the Kirkwood SoCs to the mbus
> bus node. For some reason, two boards were not properly converted
> and have their pci-controller nodes still in the ocp bus node.
>
> As the corresponding SoC pcie-controller does not exist anymore,
> it is likely that pcie is broken on those boards since above commit.
> Fix it by moving the pcie related nodes to the correct location.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>


I've tried this patch on NSA320, as expected it doesn't make any 
observable difference as there is nothing connected to the PCIe bus 
(hence not really worth a tested by). It matters more on the NSA310 as 
that uses PCIe for Ethernet.

Regards

Adam Baker

> ---
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 18 ++++++++++--------
>   arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi  | 18 ++++++++++--------
>   2 files changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> index 2cb0dc529165..4bf358c28be2 100644
> --- a/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> +++ b/arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts
> @@ -30,6 +30,16 @@
>   		bootargs = "console=ttyS0,115200n8 earlyprintk";
>   	};
>
> +	mbus {
> +		pcie-controller {
> +			status = "okay";
> +
> +			pcie@1,0 {
> +				status = "okay";
> +			};
> +		};
> +        };
> +
>   	ocp@f1000000 {
>   		pinctrl@10000 {
>   			pmx_usb_led: pmx-usb-led {
> @@ -73,14 +83,6 @@
>   		ehci@50000 {
>   			status = "okay";
>   		};
> -
> -		pcie-controller {
> -			status = "okay";
> -
> -			pcie@1,0 {
> -				status = "okay";
> -			};
> -		};
>   	};
>
>   	gpio-leds {
> diff --git a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> index 843b8b561e5e..b88810df7ca2 100644
> --- a/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-nsa3x0-common.dtsi
> @@ -4,6 +4,16 @@
>   / {
>   	model = "ZyXEL NSA310";
>
> +	mbus {
> +		pcie-controller {
> +			status = "okay";
> +
> +			pcie@1,0 {
> +				status = "okay";
> +			};
> +		};
> +	};
> +
>   	ocp@f1000000 {
>   		pinctrl: pinctrl@10000 {
>
> @@ -51,14 +61,6 @@
>   			status = "okay";
>   			nr-ports = <2>;
>   		};
> -
> -		pcie-controller {
> -			status = "okay";
> -
> -			pcie@1,0 {
> -				status = "okay";
> -			};
> -		};
>   	};
>
>   	gpio_poweroff {
>

  parent reply	other threads:[~2014-05-05 22:20 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 12:56 [PATCH 00/15] Kirkwood DT fix and cleanup round 1 Sebastian Hesselbarth
2014-04-30 12:56 ` Sebastian Hesselbarth
2014-04-30 12:56 ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 01/15] ARM: dts: kirkwood: fix mislocated pcie-controller nodes Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-05-05  0:46   ` Jason Cooper
2014-05-05  0:46     ` Jason Cooper
2014-05-05  0:46     ` Jason Cooper
2014-05-05 22:20   ` Adam Baker [this message]
2014-05-05 22:20     ` Adam Baker
2014-04-30 12:56 ` [PATCH 02/15] ARM: dts: kirkwood: add node labels Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-05-05  0:56   ` Jason Cooper
2014-05-05  0:56     ` Jason Cooper
2014-05-05  0:56     ` Jason Cooper
2014-04-30 12:56 ` [PATCH 03/15] ARM: dts: kirkwood: add stdout-path property to all boards Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 16:38   ` Andrew Lunn
2014-04-30 16:38     ` Andrew Lunn
2014-04-30 16:38     ` Andrew Lunn
2014-04-30 19:47     ` Sebastian Hesselbarth
2014-04-30 19:47       ` Sebastian Hesselbarth
2014-04-30 19:47       ` Sebastian Hesselbarth
2014-04-30 20:21       ` Andrew Lunn
2014-04-30 20:21         ` Andrew Lunn
2014-04-30 20:21         ` Andrew Lunn
2014-04-30 20:30         ` Arnd Bergmann
2014-04-30 20:30           ` Arnd Bergmann
2014-04-30 20:30           ` Arnd Bergmann
2014-05-01  7:30           ` Andrew Lunn
2014-05-01  7:30             ` Andrew Lunn
2014-04-30 12:56 ` [PATCH 04/15] ARM: dts: kirkwood: remove clock-frequency properties from UART nodes Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 05/15] ARM: dts: kirkwood: rename pin-controller nodes Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 06/15] ARM: dts: kirkwood: add pinctrl node to common SoC include Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 07/15] ARM: dts: kirkwood: consolidate common pinctrl settings Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 16:42   ` Jason Gunthorpe
2014-04-30 16:42     ` Jason Gunthorpe
2014-04-30 16:44     ` Andrew Lunn
2014-04-30 16:44       ` Andrew Lunn
2014-04-30 16:44       ` Andrew Lunn
2014-04-30 19:39     ` Sebastian Hesselbarth
2014-04-30 19:39       ` Sebastian Hesselbarth
2014-04-30 19:39       ` Sebastian Hesselbarth
2014-04-30 19:44       ` Jason Gunthorpe
2014-04-30 19:44         ` Jason Gunthorpe
2014-04-30 19:44         ` Jason Gunthorpe
2014-04-30 19:54         ` Sebastian Hesselbarth
2014-04-30 19:54           ` Sebastian Hesselbarth
2014-04-30 19:54           ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 08/15] ARM: dts: kirkwood: set default pinctrl for GBE1 Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 09/15] ARM: dts: kirkwood: set default pinctrl for UART0/1 Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 10/15] ARM: dts: kirkwood: set default pinctrl for SPI0 Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 11/15] ARM: dts: kirkwood: set default pinctrl for NAND Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 12/15] ARM: dts: kirkwood: set default pinctrl for I2C0 Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 13/15] ARM: dts: kirkwood: set default pinctrl for I2C1 on 6282 Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 14/15] ARM: dts: kirkwood: set Guruplug ethernet PHY compatible Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 12:56 ` [PATCH 15/15] ARM: dts: kirkwood: set Guruplug phy-connection-type to rgmii-id Sebastian Hesselbarth
2014-04-30 12:56   ` Sebastian Hesselbarth
2014-04-30 16:49 ` [PATCH 00/15] Kirkwood DT fix and cleanup round 1 Andrew Lunn
2014-04-30 16:49   ` Andrew Lunn
2014-04-30 16:49   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53680EAC.3090401@baker-net.org.uk \
    --to=linux@baker-net.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.