All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] coretemp.0 folder contents changed
Date: Tue, 06 May 2014 13:32:15 +0000	[thread overview]
Message-ID: <5368E45F.30301@roeck-us.net> (raw)
In-Reply-To: <20140506135558.3cafd062@endymion.delvare>

On 05/06/2014 04:55 AM, Jean Delvare wrote:
> Hi Guenter, Srinivas,
>
> On Mon, 5 May 2014 10:32:31 -0700, Guenter Roeck wrote:
>> On Mon, May 05, 2014 at 10:13:11AM -0700, Srinivas Pandruvada wrote:
>>> for kernel : 3.15.rc3 .
>>>
>>> Is there any change in the coretemp? Previously we used to see,
>>> tempx data (like temp2_input, temp2_max etc.)
>>> /sys/devices/platform/coretemp.0/.
>>
>> That isn't where you are supposed to look for hwmon attributes.
>
> Actually I used to recommend looking there when people were not using
> libsensors (e.g. for pwmconfig / fancontrol or custom scripts.) This
> path had the great merit of being stable across reboots, while hwmon
> class device numbers are not (or at least they aren't guaranteed to be.)
>
>> (...)
>> To give you the background, hwmon attributes are in the process of
>> being moved from the parent device to the hwmon device, or from
>> /sys/class/hwmon/hwmonX/device/ to /sys/class/hwmon/hwmonX/,
>> as part of an effort to streamline the code and make it more
>> consistent and maintainable.
>
> I am just realizing that we are also losing the stability of hardware
> device based paths with that move :( I suppose I shouldn't have
> bothered adding support for this to fancontrol.
>
> Don't get me wrong, I still believe this is the right move, but I fear
> that the question of persistent hwmon device names will resurface every
> now and then again. libsensors offers a solution but 1* it lacks
> support for pwm attributes and 2* it doesn't help with shell or perl
> scripts such as pwmconfig and fancontrol.
>
Can we implement a similar approach to network devices and make hwmon
path names (ie the /sys/class/hwmon/XXX path name) configurable via udev ?
Might be worth exploring.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] coretemp.0 folder contents changed
Date: Tue, 06 May 2014 06:32:15 -0700	[thread overview]
Message-ID: <5368E45F.30301@roeck-us.net> (raw)
In-Reply-To: <20140506135558.3cafd062@endymion.delvare>

On 05/06/2014 04:55 AM, Jean Delvare wrote:
> Hi Guenter, Srinivas,
>
> On Mon, 5 May 2014 10:32:31 -0700, Guenter Roeck wrote:
>> On Mon, May 05, 2014 at 10:13:11AM -0700, Srinivas Pandruvada wrote:
>>> for kernel : 3.15.rc3 .
>>>
>>> Is there any change in the coretemp? Previously we used to see,
>>> tempx data (like temp2_input, temp2_max etc.)
>>> /sys/devices/platform/coretemp.0/.
>>
>> That isn't where you are supposed to look for hwmon attributes.
>
> Actually I used to recommend looking there when people were not using
> libsensors (e.g. for pwmconfig / fancontrol or custom scripts.) This
> path had the great merit of being stable across reboots, while hwmon
> class device numbers are not (or at least they aren't guaranteed to be.)
>
>> (...)
>> To give you the background, hwmon attributes are in the process of
>> being moved from the parent device to the hwmon device, or from
>> /sys/class/hwmon/hwmonX/device/ to /sys/class/hwmon/hwmonX/,
>> as part of an effort to streamline the code and make it more
>> consistent and maintainable.
>
> I am just realizing that we are also losing the stability of hardware
> device based paths with that move :( I suppose I shouldn't have
> bothered adding support for this to fancontrol.
>
> Don't get me wrong, I still believe this is the right move, but I fear
> that the question of persistent hwmon device names will resurface every
> now and then again. libsensors offers a solution but 1* it lacks
> support for pwm attributes and 2* it doesn't help with shell or perl
> scripts such as pwmconfig and fancontrol.
>
Can we implement a similar approach to network devices and make hwmon
path names (ie the /sys/class/hwmon/XXX path name) configurable via udev ?
Might be worth exploring.

Guenter


  reply	other threads:[~2014-05-06 13:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 17:13 [lm-sensors] coretemp.0 folder contents changed Srinivas Pandruvada
2014-05-05 17:13 ` Srinivas Pandruvada
2014-05-05 17:32 ` [lm-sensors] " Guenter Roeck
2014-05-05 17:32   ` Guenter Roeck
2014-05-05 17:46   ` [lm-sensors] " Srinivas Pandruvada
2014-05-05 17:46     ` Srinivas Pandruvada
2014-05-06 11:55   ` [lm-sensors] " Jean Delvare
2014-05-06 11:55     ` Jean Delvare
2014-05-06 13:32     ` Guenter Roeck [this message]
2014-05-06 13:32       ` Guenter Roeck
2014-05-07  7:13       ` Jean Delvare
2014-05-07  7:13         ` Jean Delvare
2014-05-07 12:10         ` Guenter Roeck
2014-05-07 12:10           ` Guenter Roeck
2014-05-09  7:57           ` Jean Delvare
2014-05-09  7:57             ` Jean Delvare
2014-05-06 15:20     ` Srinivas Pandruvada
2014-05-06 15:20       ` Srinivas Pandruvada
2014-05-06 15:53       ` Srinivas Pandruvada
2014-05-06 15:53         ` Srinivas Pandruvada
2014-05-07  7:16       ` Jean Delvare
2014-05-07  7:16         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368E45F.30301@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=fenghua.yu@intel.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.