From: Michael Haggerty <mhagger@alum.mit.edu>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: [PATCH 8/9] cache-tree: convert struct cache_tree to use object_id
Date: Tue, 06 May 2014 17:02:40 +0200 [thread overview]
Message-ID: <5368F990.2040702@alum.mit.edu> (raw)
In-Reply-To: <1399147942-165308-9-git-send-email-sandals@crustytoothpaste.net>
On 05/03/2014 10:12 PM, brian m. carlson wrote:
> [...]
> diff --git a/cache-tree.c b/cache-tree.c
> index 7fa524a..b7b2d06 100644
> --- a/cache-tree.c
> +++ b/cache-tree.c
In this file I also found a couple other "20" that could be converted to
GIT_OID_RAWSZ:
Around line 369:
strbuf_add(&buffer, sha1, 20);
And around line 490 (three instances):
if (size < 20)
goto free_return;
hashcpy(it->sha1, (const unsigned char*)buf);
buf += 20;
size -= 20;
I guess a search for "\<[24][0-9]\>" will find most (but not all!) of
the literal constants that are derived from GIT_OID_RAWSZ and GIT_OID_HEXSZ.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-05-06 16:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 20:12 [RFC PATCH 0/9] Use a structure for object IDs brian m. carlson
2014-05-03 20:12 ` [PATCH 1/9] Define " brian m. carlson
2014-05-04 6:07 ` Michael Haggerty
2014-05-04 9:21 ` Johannes Sixt
2014-05-04 9:43 ` David Kastrup
2014-05-04 10:55 ` Andreas Schwab
2014-05-04 20:18 ` Johannes Sixt
2014-05-04 21:31 ` Andreas Schwab
2014-05-05 5:19 ` David Kastrup
2014-05-05 9:23 ` Andreas Schwab
2014-05-05 9:33 ` James Denholm
2014-05-05 9:50 ` David Kastrup
2014-05-05 10:52 ` Michael Haggerty
2014-05-05 11:05 ` Andreas Schwab
2014-05-05 11:23 ` David Kastrup
2014-05-05 18:16 ` Felipe Contreras
2014-05-04 12:29 ` Duy Nguyen
2014-05-04 16:07 ` brian m. carlson
2014-05-04 16:48 ` Andreas Schwab
2014-05-04 17:07 ` David Kastrup
2014-05-04 17:24 ` Andreas Schwab
2014-05-04 17:44 ` David Kastrup
2014-05-04 18:01 ` Andreas Schwab
2014-05-03 20:12 ` [PATCH 2/9] bisect.c: convert to use struct object_id brian m. carlson
2014-05-03 20:12 ` [PATCH 3/9] archive.c: " brian m. carlson
2014-05-03 20:12 ` [PATCH 4/9] zip: use GIT_OID_HEXSZ for trailers brian m. carlson
2014-05-03 20:12 ` [PATCH 5/9] branch.c: convert to use struct object_id brian m. carlson
2014-05-03 20:12 ` [PATCH 6/9] bulk-checkin.c: " brian m. carlson
2014-05-03 20:12 ` [PATCH 7/9] bundle.c: convert leaf functions to " brian m. carlson
2014-05-06 14:42 ` Michael Haggerty
2014-05-03 20:12 ` [PATCH 8/9] cache-tree: convert struct cache_tree to use object_id brian m. carlson
2014-05-06 14:53 ` Michael Haggerty
2014-05-06 15:02 ` Michael Haggerty [this message]
2014-05-03 20:12 ` [PATCH 9/9] diff: convert struct combine_diff_path to object_id brian m. carlson
2014-05-06 15:08 ` Michael Haggerty
2014-05-03 22:49 ` [RFC PATCH 0/9] Use a structure for object IDs brian m. carlson
2014-05-04 6:35 ` Michael Haggerty
2014-05-04 9:19 ` Johannes Sixt
2014-05-04 17:54 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5368F990.2040702@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.