From: David Kastrup <dak@gnu.org>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: [PATCH 1/9] Define a structure for object IDs.
Date: Sun, 04 May 2014 11:43:20 +0200 [thread overview]
Message-ID: <878uqhvpzb.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <536606AB.1020803@kdbg.org> (Johannes Sixt's message of "Sun, 04 May 2014 11:21:47 +0200")
Johannes Sixt <j6t@kdbg.org> writes:
> Am 04.05.2014 08:07, schrieb Michael Haggerty:
>> On 05/03/2014 10:12 PM, brian m. carlson wrote:
>>> Introduce a structure for object IDs. This allows us to obtain the benefits
>>> of compile-time checking for misuse. The structure is expected to remain
>>> the same size and have the same alignment requirements on all known
>>> platforms, compared to the array of unsigned char.
>>
>> Please clarify whether you plan to rely on all platforms having "the
>> same size and alignment constraints" for correctness, or whether that
>> observation of the status quo is only meant to reassure us that this
>> change won't cause memory to be wasted on padding.
>
> I think that a compiler that has different size and alignment
> requirements for the proposed struct object_id and an unsigned
> char[20] would, strictly speaking, not be a "C" compiler.
Huh? How so? There is no warranty as far as I know that a structure
with only a single member has the same size and alignment requirements
as the single member would have. There is also no guarantee as far as I
know that anything but element dereference is a valid means of
converting access to a struct to access to a sole element.
--
David Kastrup
next prev parent reply other threads:[~2014-05-04 10:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 20:12 [RFC PATCH 0/9] Use a structure for object IDs brian m. carlson
2014-05-03 20:12 ` [PATCH 1/9] Define " brian m. carlson
2014-05-04 6:07 ` Michael Haggerty
2014-05-04 9:21 ` Johannes Sixt
2014-05-04 9:43 ` David Kastrup [this message]
2014-05-04 10:55 ` Andreas Schwab
2014-05-04 20:18 ` Johannes Sixt
2014-05-04 21:31 ` Andreas Schwab
2014-05-05 5:19 ` David Kastrup
2014-05-05 9:23 ` Andreas Schwab
2014-05-05 9:33 ` James Denholm
2014-05-05 9:50 ` David Kastrup
2014-05-05 10:52 ` Michael Haggerty
2014-05-05 11:05 ` Andreas Schwab
2014-05-05 11:23 ` David Kastrup
2014-05-05 18:16 ` Felipe Contreras
2014-05-04 12:29 ` Duy Nguyen
2014-05-04 16:07 ` brian m. carlson
2014-05-04 16:48 ` Andreas Schwab
2014-05-04 17:07 ` David Kastrup
2014-05-04 17:24 ` Andreas Schwab
2014-05-04 17:44 ` David Kastrup
2014-05-04 18:01 ` Andreas Schwab
2014-05-03 20:12 ` [PATCH 2/9] bisect.c: convert to use struct object_id brian m. carlson
2014-05-03 20:12 ` [PATCH 3/9] archive.c: " brian m. carlson
2014-05-03 20:12 ` [PATCH 4/9] zip: use GIT_OID_HEXSZ for trailers brian m. carlson
2014-05-03 20:12 ` [PATCH 5/9] branch.c: convert to use struct object_id brian m. carlson
2014-05-03 20:12 ` [PATCH 6/9] bulk-checkin.c: " brian m. carlson
2014-05-03 20:12 ` [PATCH 7/9] bundle.c: convert leaf functions to " brian m. carlson
2014-05-06 14:42 ` Michael Haggerty
2014-05-03 20:12 ` [PATCH 8/9] cache-tree: convert struct cache_tree to use object_id brian m. carlson
2014-05-06 14:53 ` Michael Haggerty
2014-05-06 15:02 ` Michael Haggerty
2014-05-03 20:12 ` [PATCH 9/9] diff: convert struct combine_diff_path to object_id brian m. carlson
2014-05-06 15:08 ` Michael Haggerty
2014-05-03 22:49 ` [RFC PATCH 0/9] Use a structure for object IDs brian m. carlson
2014-05-04 6:35 ` Michael Haggerty
2014-05-04 9:19 ` Johannes Sixt
2014-05-04 17:54 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uqhvpzb.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=mhagger@alum.mit.edu \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.