From: Goffredo Baroncelli <kreijack@libero.it>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Cc: Anand Jain <Anand.Jain@oracle.com>
Subject: Re: [RFC PATCH 0/2] Kernel space btrfs missing device detection.
Date: Tue, 06 May 2014 20:10:47 +0200 [thread overview]
Message-ID: <536925A7.4000201@libero.it> (raw)
In-Reply-To: <1399357993-9254-1-git-send-email-quwenruo@cn.fujitsu.com>
Hi,
instead of extending the BTRFS_IOCTL_DEV_INFO ioctl, why do not add a field under /sys/fs/btrfs/<UUID>/ ? Something like /sys/fs/btrfs/<UUID>/missing_device
BR
G.Baroncelli
On 05/06/2014 08:33 AM, Qu Wenruo wrote:
> Original btrfs will not detection any missing device since there is
> no notification mechanism for fs layer to detect missing device in
> block layer.
>
> However we don't really need to notify fs layer upon dev remove,
> probing in dev_info/rm_dev ioctl is good enough since they are the
> only two ioctls caring about missing device.
>
> This patchset will do ioctl time missing dev detection and return
> device missing status in dev_info ioctl using a new member in
> btrfs_ioctl_dev_info_args with a backward compatible method.
>
> Cc: Anand Jain <Anand.Jain@oracle.com> Qu Wenruo (2): btrfs: Add
> missing device check in dev_info/rm_dev ioctl btrfs: Add new member
> of btrfs_ioctl_dev_info_args.
>
> fs/btrfs/ioctl.c | 4 ++++ fs/btrfs/volumes.c | 25
> ++++++++++++++++++++++++- fs/btrfs/volumes.h | 2 ++
> include/uapi/linux/btrfs.h | 5 ++++- 4 files changed, 34
> insertions(+), 2 deletions(-)
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2014-05-06 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 6:33 [RFC PATCH 0/2] Kernel space btrfs missing device detection Qu Wenruo
2014-05-06 6:33 ` [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl Qu Wenruo
2014-05-07 8:00 ` Anand Jain
2014-05-07 8:02 ` Qu Wenruo
2014-05-21 3:12 ` Qu Wenruo
2014-05-21 3:54 ` Anand Jain
2014-05-21 4:15 ` Qu Wenruo
2014-05-21 18:26 ` Brendan Hide
2014-05-21 3:47 ` Anand Jain
2014-05-06 6:33 ` [RFC PATCH 2/2] btrfs: Add new member of btrfs_ioctl_dev_info_args Qu Wenruo
2014-05-06 18:10 ` Goffredo Baroncelli [this message]
2014-05-07 1:48 ` [RFC PATCH 0/2] Kernel space btrfs missing device detection Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536925A7.4000201@libero.it \
--to=kreijack@libero.it \
--cc=Anand.Jain@oracle.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.