From: Brendan Hide <brendan@swiftspirit.co.za>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, Anand Jain <Anand.Jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl
Date: Wed, 21 May 2014 20:26:30 +0200 [thread overview]
Message-ID: <537CEFD6.9010407@swiftspirit.co.za> (raw)
In-Reply-To: <537C285F.7080101@cn.fujitsu.com>
On 2014/05/21 06:15 AM, Qu Wenruo wrote:
> [snip]
>> Further on top of your check_missing patch I am writing
>> code to to handle disk reappear. I should be sending them
>> all soon.
> Disk reappear problem is also reproduce here.
>
> I am intersting about how will your patch to deal with.
> Is your patch going to check super genertion to determing previously
> missing device and
> wipe reappeared superblock?(Wang mentioned it in the mail in Jan.)
With md we have the bitmap feature that helps prevent resynchronising
the entire disk when doing a "re-add". Wiping the superblock is *better*
than what we currently have (corruption) - but hopefully the end goal is
to be able to have it re-add *without* introducing corruption.
>
> IMO the reappear disk problem can also be resolved by not swap
> tgtdev->uuid and srcdev->uuid,
> which means tgtdev will not use the same uuid of srcdev.
>
> Thanks,
> Qu
>>
>> Thanks, Anand
>>
--
__________
Brendan Hide
http://swiftspirit.co.za/
http://www.webafrica.co.za/?AFF1E97
next prev parent reply other threads:[~2014-05-21 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 6:33 [RFC PATCH 0/2] Kernel space btrfs missing device detection Qu Wenruo
2014-05-06 6:33 ` [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl Qu Wenruo
2014-05-07 8:00 ` Anand Jain
2014-05-07 8:02 ` Qu Wenruo
2014-05-21 3:12 ` Qu Wenruo
2014-05-21 3:54 ` Anand Jain
2014-05-21 4:15 ` Qu Wenruo
2014-05-21 18:26 ` Brendan Hide [this message]
2014-05-21 3:47 ` Anand Jain
2014-05-06 6:33 ` [RFC PATCH 2/2] btrfs: Add new member of btrfs_ioctl_dev_info_args Qu Wenruo
2014-05-06 18:10 ` [RFC PATCH 0/2] Kernel space btrfs missing device detection Goffredo Baroncelli
2014-05-07 1:48 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CEFD6.9010407@swiftspirit.co.za \
--to=brendan@swiftspirit.co.za \
--cc=Anand.Jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.