* [PATCH] leds: lp55xx: add DT bindings for LP55231
@ 2014-05-05 11:46 Daniel Mack
2014-05-06 23:09 ` Milo Kim
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Mack @ 2014-05-05 11:46 UTC (permalink / raw)
To: cooloney, rpurdie, samu.p.onkalo, milo.kim; +Cc: linux-leds, Daniel Mack
The TI55231 appears to be fully compatible to the 5523 model from
National Semicondutor. This patch just adds DT bindings for it.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 8 +++++++-
drivers/leds/leds-lp5523.c | 3 ++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
index c55b8c0..1b66a41 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
+++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt
@@ -1,7 +1,13 @@
Binding for TI/National Semiconductor LP55xx Led Drivers
Required properties:
-- compatible: "national,lp5521" or "national,lp5523" or "ti,lp5562" or "ti,lp8501"
+- compatible: one of
+ national,lp5521
+ national,lp5523
+ ti,lp55231
+ ti,lp5562
+ ti,lp8501
+
- reg: I2C slave address
- clock-mode: Input clock mode, (0: automode, 1: internal, 2: external)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 4ade66a..7e46f57 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -1,5 +1,5 @@
/*
- * lp5523.c - LP5523 LED Driver
+ * lp5523.c - LP5523, LP55231 LED Driver
*
* Copyright (C) 2010 Nokia Corporation
* Copyright (C) 2012 Texas Instruments
@@ -815,6 +815,7 @@ MODULE_DEVICE_TABLE(i2c, lp5523_id);
#ifdef CONFIG_OF
static const struct of_device_id of_lp5523_leds_match[] = {
{ .compatible = "national,lp5523", },
+ { .compatible = "ti,lp55231", },
{},
};
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: lp55xx: add DT bindings for LP55231
2014-05-05 11:46 [PATCH] leds: lp55xx: add DT bindings for LP55231 Daniel Mack
@ 2014-05-06 23:09 ` Milo Kim
2014-05-08 1:55 ` Bryan Wu
0 siblings, 1 reply; 3+ messages in thread
From: Milo Kim @ 2014-05-06 23:09 UTC (permalink / raw)
To: Daniel Mack; +Cc: cooloney, rpurdie, samu.p.onkalo, linux-leds
On 05/05/2014 08:46 PM, Daniel Mack wrote:
> The TI55231 appears to be fully compatible to the 5523 model from
> National Semicondutor. This patch just adds DT bindings for it.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Milo Kim <milo.kim@ti.com>
Thanks!
You got a good point. Vendor name is correct because LP55231 was
released not by National but by TI.
Best regards,
Milo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: lp55xx: add DT bindings for LP55231
2014-05-06 23:09 ` Milo Kim
@ 2014-05-08 1:55 ` Bryan Wu
0 siblings, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2014-05-08 1:55 UTC (permalink / raw)
To: Milo Kim; +Cc: Daniel Mack, rpurdie@rpsys.net, samu.p.onkalo,
Linux LED Subsystem
On Tue, May 6, 2014 at 4:09 PM, Milo Kim <milo.kim@ti.com> wrote:
> On 05/05/2014 08:46 PM, Daniel Mack wrote:
>>
>> The TI55231 appears to be fully compatible to the 5523 model from
>> National Semicondutor. This patch just adds DT bindings for it.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>
>
> Acked-by: Milo Kim <milo.kim@ti.com>
>
Applied with Milo's ACK,
Thanks,
-Bryan
> Thanks!
> You got a good point. Vendor name is correct because LP55231 was released
> not by National but by TI.
>
> Best regards,
> Milo
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-08 1:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-05 11:46 [PATCH] leds: lp55xx: add DT bindings for LP55231 Daniel Mack
2014-05-06 23:09 ` Milo Kim
2014-05-08 1:55 ` Bryan Wu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.