Re: [PATCH v4 5/5] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients

[Rajendra Nayak <rnayak@ti.com>]

On Tuesday 06 May 2014 09:58 PM, Tony Lindgren wrote:
> * Rajendra Nayak <rnayak@ti.com> [140429 04:22]:
>> On Tuesday 29 April 2014 04:48 PM, Arnd Bergmann wrote:
>>> On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote:
>>>> @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430)
>>>>  
>>>>  #if defined(CONFIG_SOC_DRA7XX)
>>>>  #undef soc_is_dra7xx
>>>> +#undef soc_is_dra74x
>>>> +#undef soc_is_dra72x
>>>>  #define soc_is_dra7xx()        (of_machine_is_compatible("ti,dra7"))
>>>> +#define soc_is_dra74x()        (of_machine_is_compatible("ti,dra74"))
>>>> +#define soc_is_dra72x()        (of_machine_is_compatible("ti,dra72"))
>>>> +
>>>
>>> You shouldn't normally have to define these. Why are they needed?
>>>
>>> Maybe it's better to wait for a user to show up, and then we can decide
>>> whether we actually want to have them this way, or if there is a better
>>> solution for the particular use case.
>>>
>>> Normally, we'd want to make run-time decisions based on properties
>>> of the nodes a driver is working on, not the global machine compatible
>>> string.
>>
>> Yeah, actually this can be dropped. There is no user for it now.
> 
> OK applying all but the last patch into omap-for-v3.16/dt branch,
> it seems there's no need to separate out the fixes in this case.

Thanks Tony.

> 
> Regards,
> 
> Tony
>