From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Igor Ryzhov <iryzhov-p3dJzl6UAic@public.gmane.org>,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: RTE Ring removing
Date: Wed, 07 May 2014 15:08:10 +0200 [thread overview]
Message-ID: <536A303A.5040702@6wind.com> (raw)
In-Reply-To: <536A2A44.1030801-p3dJzl6UAic@public.gmane.org>
Hi Igor,
On 05/07/2014 02:42 PM, Igor Ryzhov wrote:
> But a few questions:
> 1. Will this changes affect performance?
It should not. If you have many rings, you may allocate them
in huge pages to avoid TLB misses.
> 2. In PATCH 2/2 you have a small bug:
>
> In file rte_ring.h, in comments describing rte_ring_init function you have:
>
> + * @param name
> + * The size of the ring.
>
> But it is name of the ring, not size.
Thank you for this comment, I'll fix it in the v2.
Regards,
Olivier
next prev parent reply other threads:[~2014-05-07 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 9:05 RTE Ring removing Igor Ryzhov
[not found] ` <5368A5E0.8090903-p3dJzl6UAic@public.gmane.org>
2014-05-07 7:54 ` Igor Ryzhov
[not found] ` <5369E6AF.4040402-p3dJzl6UAic@public.gmane.org>
2014-05-07 11:39 ` Olivier MATZ
[not found] ` <536A1B5C.2010201-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-07 12:42 ` Igor Ryzhov
[not found] ` <536A2A44.1030801-p3dJzl6UAic@public.gmane.org>
2014-05-07 13:08 ` Olivier MATZ [this message]
2014-05-07 14:01 ` Venkatesan, Venky
[not found] ` <1FD9B82B8BF2CF418D9A1000154491D9740A339F-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-07 15:09 ` Olivier MATZ
[not found] ` <536A4CB3.9000005-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-05-07 15:19 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB9772580EFA401D-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-07 15:37 ` Olivier MATZ
2014-05-07 15:36 ` Rogers, Gerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A303A.5040702@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=iryzhov-p3dJzl6UAic@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.