Re: [Qemu-trivial] [Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

[Michael Tokarev <mjt@tls.msk.ru>]

07.05.2014 16:50, Peter Maydell wrote:

> Hi; I'm afraid this pull breaks the build of the A64 disassembler:
> 
> c++ -I/home/petmay01/linaro/qemu-for-merges/tcg
> -I/home/petmay01/linaro/qemu-for-merges/tcg/i386
> -I/home/petmay01/linaro/qemu-for-merges/linux-headers
> -I/home/petmay01/linaro/qemu-for-merges/build/alldbg/linux-headers -I.
> -I/home/petmay01/linaro/qemu-for-merges
> -I/home/petmay01/linaro/qemu-for-merges/include
> -I/home/petmay01/linaro/qemu-for-merges/libcacard
> -I/home/petmay01/linaro/qemu-for-merges/disas -Idisas
> -D__STDC_LIMIT_MACROS -Werror -fPIE -DPIE -m64 -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wall -Wundef
> -Wwrite-strings -fno-strict-aliasing -fno-common -Wendif-labels
> -Wmissing-include-dirs -Wempty-body -Wformat-security -Wformat-y2k
> -Winit-self -Wignored-qualifiers -Wtype-limits -fstack-protector-all
> -I/usr/include/p11-kit-1 -I/usr/include/libpng12 -I/usr/include/nss
> -I/usr/include/nspr -pthread -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1
> -I/home/petmay01/linaro/qemu-for-merges/tests -MMD -MP -MT
> disas/arm-a64.o -MF disas/arm-a64.d -pthread -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include   -g  -c -o
> disas/arm-a64.o /home/petmay01/linaro/qemu-for-merges/disas/arm-a64.cc
> /home/petmay01/linaro/qemu-for-merges/disas/arm-a64.cc:20:28: fatal
> error: a64/disasm-a64.h: No such file or directory
> compilation terminated.
> make: *** [disas/arm-a64.o] Error 1
> 
>>       Makefiles: convert some obj-specific CFLAGS to use new foo.o-cflags syntax
> 
> git bisect says it's this makefile change.
> 
> I think the problem here is that the rune for applying obj-specific
> CFLAGS is only in the Rules.make line for %.o: %.c, and not in
> the lines for building a .o file from a .cc, .cpp or .m file. That
> should probably be fixed.

Interesting.  It looks like I should add C++ compiler to my test environment,
because I really verified the change and it builds here just fine, but it does
not detect C++ so does not try to build C++ files.

Lovely.

I'm resending the patchset without this patch, will work on it more.

Thank you, and sorry for the noize.

/mjt