From: Felix Fietkau <nbd@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002
Date: Wed, 07 May 2014 22:15:53 +0200 [thread overview]
Message-ID: <536A9479.8010201@openwrt.org> (raw)
In-Reply-To: <20140507195435.GF20432@tuxdriver.com>
On 2014-05-07 21:54, John W. Linville wrote:
> On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote:
>> ah->caldata may be NULL if no channel is selected. Check for that before
>> accessing it.
>>
>> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>> ---
>> Hi
>>
>> This is _definitely_ only a workaround, given that no-one guarantees ah->caldata
>> is freed while we run in hw_per_calibration(). However, this patch fixes serious
>> kernel panics with wifi-P2P on my machine.
>>
>> I'm not sure why ah->caldata can be NULL, but it definitely is. I think the
>> correct fix would be to synchronously stop any running hw-calibration before
>> setting ah->caldata to NULL. I don't know whether/where that is done, so I wrote
>> this small workaround.
>>
>> Thanks
>> David
>
> Is there any hope for getting a more complete fix from the ath9k guys
> in short order?
This looks easy to fix. I'll send a patch soon.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@openwrt.org>
To: "John W. Linville" <linville@tuxdriver.com>,
David Herrmann <dh.herrmann@gmail.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
Jouni Malinen <jouni@qca.qualcomm.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Subject: Re: [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002
Date: Wed, 07 May 2014 22:15:53 +0200 [thread overview]
Message-ID: <536A9479.8010201@openwrt.org> (raw)
In-Reply-To: <20140507195435.GF20432@tuxdriver.com>
On 2014-05-07 21:54, John W. Linville wrote:
> On Wed, May 07, 2014 at 09:22:58AM +0200, David Herrmann wrote:
>> ah->caldata may be NULL if no channel is selected. Check for that before
>> accessing it.
>>
>> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>> ---
>> Hi
>>
>> This is _definitely_ only a workaround, given that no-one guarantees ah->caldata
>> is freed while we run in hw_per_calibration(). However, this patch fixes serious
>> kernel panics with wifi-P2P on my machine.
>>
>> I'm not sure why ah->caldata can be NULL, but it definitely is. I think the
>> correct fix would be to synchronously stop any running hw-calibration before
>> setting ah->caldata to NULL. I don't know whether/where that is done, so I wrote
>> this small workaround.
>>
>> Thanks
>> David
>
> Is there any hope for getting a more complete fix from the ath9k guys
> in short order?
This looks easy to fix. I'll send a patch soon.
- Felix
next prev parent reply other threads:[~2014-05-07 20:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 7:22 [ath9k-devel] [PATCH] ath9k: fix NULL-deref in hw_per_calibration() for ar9002 David Herrmann
2014-05-07 7:22 ` David Herrmann
2014-05-07 19:54 ` [ath9k-devel] " John W. Linville
2014-05-07 19:54 ` John W. Linville
2014-05-07 20:03 ` [ath9k-devel] " Luis R. Rodriguez
2014-05-07 20:03 ` Luis R. Rodriguez
2014-05-07 20:38 ` John W. Linville
2014-05-07 20:38 ` John W. Linville
2014-05-07 20:15 ` Felix Fietkau [this message]
2014-05-07 20:15 ` Felix Fietkau
2014-05-12 17:49 ` John W. Linville
2014-05-12 17:49 ` John W. Linville
2014-05-12 18:43 ` Felix Fietkau
2014-05-12 18:43 ` Felix Fietkau
2014-05-13 6:50 ` David Herrmann
2014-05-13 6:50 ` David Herrmann
2014-05-13 9:00 ` Rajkumar Manoharan
2014-05-13 9:00 ` Rajkumar Manoharan
2014-05-13 9:09 ` David Herrmann
2014-05-13 9:09 ` David Herrmann
2014-05-13 10:41 ` Rajkumar Manoharan
2014-05-13 10:41 ` Rajkumar Manoharan
2014-05-13 18:21 ` David Herrmann
2014-05-13 18:21 ` David Herrmann
2014-05-08 18:18 ` Rajkumar Manoharan
2014-05-08 18:18 ` Rajkumar Manoharan
2014-05-08 20:16 ` [ath9k-devel] " David Herrmann
2014-05-08 20:16 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A9479.8010201@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.