From: yoshihiro.shimoda.uh@renesas.com (Shimoda, Yoshihiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 08/20] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers
Date: Thu, 8 May 2014 11:44:48 +0900 [thread overview]
Message-ID: <536AEFA0.3070806@renesas.com> (raw)
In-Reply-To: <1399470746-2948-9-git-send-email-thomas.petazzoni@free-electrons.com>
Hi,
(2014/05/07 22:52), Thomas Petazzoni wrote:
> diff --git a/drivers/usb/host/xhci-mvebu.h b/drivers/usb/host/xhci-mvebu.h
> new file mode 100644
> index 0000000..61d09b6
> --- /dev/null
> +++ b/drivers/usb/host/xhci-mvebu.h
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (C) 2014 Marvell
> + *
> + * Gregory Clement <gregory.clement@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#ifndef __LINUX_XHCI_MVEBU_H
> +#define __LINUX_XHCI_MVEBU_H
> +#if IS_ENABLED(CONFIG_USB_XHCI_MVEBU)
> +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev);
> +#else
> +static inline int xhci_mvebu_mbus_init_quirk(struct device dev)
I could not compile this code when I disabled CONFIG_USB_XHCI_MVEBU:
incompatible type for argument 1 of 'xhci_mvebu_mbus_init_quirk'.
So, the "struct device dev" should be changed to "struct platform_device *pdev".
Best regards,
Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Cc: Lior Amsalem <alior@marvell.com>,
Grant Likely <grant.likely@secretlab.ca>,
Tawfik Bayouk <tawfik@marvell.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Nadav Haklai <nadavh@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv4 08/20] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers
Date: Thu, 8 May 2014 11:44:48 +0900 [thread overview]
Message-ID: <536AEFA0.3070806@renesas.com> (raw)
In-Reply-To: <1399470746-2948-9-git-send-email-thomas.petazzoni@free-electrons.com>
Hi,
(2014/05/07 22:52), Thomas Petazzoni wrote:
> diff --git a/drivers/usb/host/xhci-mvebu.h b/drivers/usb/host/xhci-mvebu.h
> new file mode 100644
> index 0000000..61d09b6
> --- /dev/null
> +++ b/drivers/usb/host/xhci-mvebu.h
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright (C) 2014 Marvell
> + *
> + * Gregory Clement <gregory.clement@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#ifndef __LINUX_XHCI_MVEBU_H
> +#define __LINUX_XHCI_MVEBU_H
> +#if IS_ENABLED(CONFIG_USB_XHCI_MVEBU)
> +int xhci_mvebu_mbus_init_quirk(struct platform_device *pdev);
> +#else
> +static inline int xhci_mvebu_mbus_init_quirk(struct device dev)
I could not compile this code when I disabled CONFIG_USB_XHCI_MVEBU:
incompatible type for argument 1 of 'xhci_mvebu_mbus_init_quirk'.
So, the "struct device dev" should be changed to "struct platform_device *pdev".
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2014-05-08 2:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 13:52 [PATCHv4 00/20] USB support for Armada 38x and Armada 375 Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 01/20] usb: ehci-orion: use platform_get_irq() for DT probing Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 15:09 ` Alan Stern
2014-05-07 15:09 ` Alan Stern
2014-05-07 13:52 ` [PATCHv4 02/20] usb: ehci-orion: rename error goto labels in ehci_orion_drv_probe() Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 03/20] usb: ehci-orion: fix clock reference leaking Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 04/20] usb: ehci-orion: add optional PHY support Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 05/20] Documentation: dt-bindings: update ehci-orion binding documentation Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 06/20] usb: host: xhci-plat: sort the headers in alphabetic order Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 07/20] usb: host: xhci-plat: add clock support Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 08/20] usb: host: xhci-plat: add support for the Armada 375/38x XHCI controllers Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-08 2:44 ` Shimoda, Yoshihiro [this message]
2014-05-08 2:44 ` Shimoda, Yoshihiro
2014-05-11 18:12 ` Thomas Petazzoni
2014-05-11 18:12 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 09/20] Documentation: dt-bindings: update xhci-platform DT binding Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 10/20] phy: add support for USB cluster on the Armada 375 SoC Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 11/20] Documentation: dt-bindings: document the Armada 375 USB cluster binding Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 12/20] ARM: mvebu: add USB3 support for Armada 38x Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 13/20] ARM: mvebu: add USB3 support for Armada 375 Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 14/20] ARM: configs: enable XHCI mvebu support in mvebu_v7_defconfig Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 15/20] ARM: configs: enable XHCI mvebu support in multi_v7_defconfig Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-16 23:08 ` Olof Johansson
2014-05-16 23:08 ` Olof Johansson
2014-05-07 13:52 ` [PATCHv4 16/20] ARM: mvebu: add Device Tree description of xHCI controllers on Armada 38x Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 17/20] ARM: mvebu: add Device Tree description of the EHCI controller " Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 18/20] ARM: mvebu: add Device Tree description of USB cluster controller on Armada 375 Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 19/20] ARM: mvebu: add Device Tree description of the xHCI " Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
2014-05-07 13:52 ` [PATCHv4 20/20] ARM: mvebu: add Device Tree description of the EHCI " Thomas Petazzoni
2014-05-07 13:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536AEFA0.3070806@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.