From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: tony@atomide.com, t-kristo@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, santosh.shilimkar@ti.com
Subject: Re: [PATCH 1/2] ARM: omap5: hwmod_data: Update McPDM hwmod's flags
Date: Thu, 8 May 2014 13:08:16 +0300 [thread overview]
Message-ID: <536B5790.1050800@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405080018490.23579@utopia.booyaka.com>
Hi Paul,
On 05/08/2014 03:20 AM, Paul Walmsley wrote:
> Hi Péter,
>
> On Wed, 30 Apr 2014, Peter Ujfalusi wrote:
>
>> Add HWMOD_SWSUP_SIDLE to flags.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> This patch could use a better changelog. It would be ideal to understand
> _why_ HWMOD_SWSUP_SIDLE is needed. Is there a known hardware bug? Or is
> this simply based on practical observation, e.g., something bad happens if
> the McPDM is not software-idled?
The same issue exists on OMAP5 as on OMAP4:
commit 12d82e4b0aa6c71f38b668a372f9a13f243207da
Author: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Fri Jan 18 16:48:16 2013 -0700
ARM: OMAP4: hwmod_data: Correct IDLEMODE for McPDM
McPDM need to be configured to NO_IDLE mode when it is in used otherwise
vital clocks will be gated which results 'slow motion' audio playback.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[paul@pwsan.com: copy patch description into hwmod data comments]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: omap5: hwmod_data: Update McPDM hwmod's flags
Date: Thu, 8 May 2014 13:08:16 +0300 [thread overview]
Message-ID: <536B5790.1050800@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405080018490.23579@utopia.booyaka.com>
Hi Paul,
On 05/08/2014 03:20 AM, Paul Walmsley wrote:
> Hi P?ter,
>
> On Wed, 30 Apr 2014, Peter Ujfalusi wrote:
>
>> Add HWMOD_SWSUP_SIDLE to flags.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> This patch could use a better changelog. It would be ideal to understand
> _why_ HWMOD_SWSUP_SIDLE is needed. Is there a known hardware bug? Or is
> this simply based on practical observation, e.g., something bad happens if
> the McPDM is not software-idled?
The same issue exists on OMAP5 as on OMAP4:
commit 12d82e4b0aa6c71f38b668a372f9a13f243207da
Author: Peter Ujfalusi <peter.ujfalusi@ti.com>
Date: Fri Jan 18 16:48:16 2013 -0700
ARM: OMAP4: hwmod_data: Correct IDLEMODE for McPDM
McPDM need to be configured to NO_IDLE mode when it is in used otherwise
vital clocks will be gated which results 'slow motion' audio playback.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
[paul at pwsan.com: copy patch description into hwmod data comments]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
--
P?ter
next prev parent reply other threads:[~2014-05-08 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 11:43 [PATCH 1/2] ARM: omap5: hwmod_data: Update McPDM hwmod's flags Peter Ujfalusi
2014-04-30 11:43 ` Peter Ujfalusi
2014-04-30 11:43 ` [PATCH 2/2] ARM: omap5: hwmod_data: Add AESS related data Peter Ujfalusi
2014-04-30 11:43 ` Peter Ujfalusi
2014-05-09 8:00 ` Peter Ujfalusi
2014-05-09 8:00 ` Peter Ujfalusi
2014-05-08 0:20 ` [PATCH 1/2] ARM: omap5: hwmod_data: Update McPDM hwmod's flags Paul Walmsley
2014-05-08 0:20 ` Paul Walmsley
2014-05-08 10:08 ` Peter Ujfalusi [this message]
2014-05-08 10:08 ` Peter Ujfalusi
2014-05-08 16:03 ` Paul Walmsley
2014-05-08 16:03 ` Paul Walmsley
2014-05-09 8:10 ` [PATCH v2] ARM: omap5: hwmod_data: Correct IDLEMODE for McPDM Peter Ujfalusi
2014-05-09 8:10 ` Peter Ujfalusi
2014-05-14 17:13 ` Paul Walmsley
2014-05-14 17:13 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B5790.1050800@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.