From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Bastian Hecht <hechtb+renesas@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support
Date: Thu, 08 May 2014 13:14:40 +0000 [thread overview]
Message-ID: <536B8340.4010901@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdVoYnRcOVht0_Bt5_NJA3vZ40svftRXN-xbqHSMHZR5dg@mail.gmail.com>
On 05/08/2014 05:06 PM, Geert Uytterhoeven wrote:
>>> + ether: ethernet@e9a00000 {
>> Are you really going to refer to this node somewhere, using its label?
> Yes, from r8a7740-armadillo800eva-reference.dts
Ah, I completely forgot that there should be a board specific part of the
node. Sorry.
>>> + compatible = "renesas,gether-r8a7740";
>>> + reg = <0xe9a00000 0x800>,
>>> + <0xe9a01800 0x800>;
>>> + interrupt-parent = <&gic>;
>>> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
>>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
>> This property is mandatory, according to the bindings.
> Indeed, but you cannot put anything there until the platform has CCF, as
> mstp3_clks doesn't exist yet.
Yes, that was the main obstacle to accepting those bindings sooner. This
patch therefore seems somewhat premature.
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Bastian Hecht <hechtb+renesas@gmail.com>,
Linux-sh list <linux-sh@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support
Date: Thu, 08 May 2014 17:14:40 +0400 [thread overview]
Message-ID: <536B8340.4010901@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdVoYnRcOVht0_Bt5_NJA3vZ40svftRXN-xbqHSMHZR5dg@mail.gmail.com>
On 05/08/2014 05:06 PM, Geert Uytterhoeven wrote:
>>> + ether: ethernet@e9a00000 {
>> Are you really going to refer to this node somewhere, using its label?
> Yes, from r8a7740-armadillo800eva-reference.dts
Ah, I completely forgot that there should be a board specific part of the
node. Sorry.
>>> + compatible = "renesas,gether-r8a7740";
>>> + reg = <0xe9a00000 0x800>,
>>> + <0xe9a01800 0x800>;
>>> + interrupt-parent = <&gic>;
>>> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
>>> + /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */
>> This property is mandatory, according to the bindings.
> Indeed, but you cannot put anything there until the platform has CCF, as
> mstp3_clks doesn't exist yet.
Yes, that was the main obstacle to accepting those bindings sooner. This
patch therefore seems somewhat premature.
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
next prev parent reply other threads:[~2014-05-08 13:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 20:32 [PATCH 1/3] ARM: shmobile: r8a7740: Correct name of DT Ethernet clock Geert Uytterhoeven
2014-05-07 20:32 ` Geert Uytterhoeven
[not found] ` <1399494750-31996-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-05-07 20:32 ` [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support Geert Uytterhoeven
2014-05-07 20:32 ` Geert Uytterhoeven
2014-05-07 20:32 ` Geert Uytterhoeven
2014-05-08 12:59 ` Sergei Shtylyov
2014-05-08 13:00 ` Sergei Shtylyov
[not found] ` <536B7FD3.5090506-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-08 13:06 ` Geert Uytterhoeven
2014-05-08 13:06 ` Geert Uytterhoeven
2014-05-08 13:06 ` Geert Uytterhoeven
2014-05-08 13:14 ` Sergei Shtylyov [this message]
2014-05-08 13:14 ` Sergei Shtylyov
2014-05-08 13:21 ` Geert Uytterhoeven
2014-05-08 13:21 ` Geert Uytterhoeven
2014-05-08 17:52 ` Sergei Shtylyov
2014-05-08 17:52 ` Sergei Shtylyov
2014-05-08 18:46 ` Geert Uytterhoeven
2014-05-08 18:46 ` Geert Uytterhoeven
2014-05-08 18:52 ` Sergei Shtylyov
2014-05-08 18:52 ` Sergei Shtylyov
2014-05-08 19:01 ` Geert Uytterhoeven
2014-05-08 19:01 ` Geert Uytterhoeven
2014-05-11 1:00 ` Simon Horman
2014-05-11 1:00 ` Simon Horman
2014-05-11 13:48 ` Sergei Shtylyov
2014-05-11 13:48 ` Sergei Shtylyov
[not found] ` <536F7FB6.5090508-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-11 22:49 ` Simon Horman
2014-05-11 22:49 ` Simon Horman
2014-05-11 22:49 ` Simon Horman
2014-05-11 2:25 ` Simon Horman
2014-05-11 2:25 ` Simon Horman
2014-05-07 20:32 ` [PATCH 3/3] ARM: shmobile: armadillo-reference dts: " Geert Uytterhoeven
2014-05-07 20:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536B8340.4010901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=hechtb+renesas@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.