All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/exynos: Fix double locks at PM resume
Date: Fri, 09 May 2014 17:50:18 +0900	[thread overview]
Message-ID: <536C96CA.6000102@samsung.com> (raw)
In-Reply-To: <1399616055-13427-2-git-send-email-tiwai@suse.de>

Hi,

On 2014년 05월 09일 15:14, Takashi Iwai wrote:
> The recent commit [3ea87855: drm/helper: lock all around force mode
> restore] introduced drm_modeset_lock_all() in
> drm_helper_resume_force_mode() itself, while exynos driver takes this
> lock before calling it.  Move the function call outside the lock for
> avoiding a deadlock.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 2d27ba23a6a8..79410b0c4bbf 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -183,9 +183,9 @@ static int exynos_drm_resume(struct drm_device *dev)
>  		if (connector->funcs->dpms)
>  			connector->funcs->dpms(connector, connector->dpms);
>  	}
> +	drm_modeset_unlock_all(dev);
>  
>  	drm_helper_resume_force_mode(dev);
> -	drm_modeset_unlock_all(dev);

This patch had already been posted but your patch comments what was the
problem more exactly than below one.
        http://www.spinics.net/lists/dri-devel/msg58586.html

So picked it up instead of previous one.

Thanks,
Inki Dae

>  
>  	return 0;
>  }
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Inki Dae <inki.dae@samsung.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/exynos: Fix double locks at PM resume
Date: Fri, 09 May 2014 17:50:18 +0900	[thread overview]
Message-ID: <536C96CA.6000102@samsung.com> (raw)
In-Reply-To: <1399616055-13427-2-git-send-email-tiwai@suse.de>

Hi,

On 2014년 05월 09일 15:14, Takashi Iwai wrote:
> The recent commit [3ea87855: drm/helper: lock all around force mode
> restore] introduced drm_modeset_lock_all() in
> drm_helper_resume_force_mode() itself, while exynos driver takes this
> lock before calling it.  Move the function call outside the lock for
> avoiding a deadlock.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 2d27ba23a6a8..79410b0c4bbf 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -183,9 +183,9 @@ static int exynos_drm_resume(struct drm_device *dev)
>  		if (connector->funcs->dpms)
>  			connector->funcs->dpms(connector, connector->dpms);
>  	}
> +	drm_modeset_unlock_all(dev);
>  
>  	drm_helper_resume_force_mode(dev);
> -	drm_modeset_unlock_all(dev);

This patch had already been posted but your patch comments what was the
problem more exactly than below one.
        http://www.spinics.net/lists/dri-devel/msg58586.html

So picked it up instead of previous one.

Thanks,
Inki Dae

>  
>  	return 0;
>  }
> 


  reply	other threads:[~2014-05-09  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09  6:14 [PATCH 1/2] drm/ast: Fix double lock at PM resume Takashi Iwai
2014-05-09  6:14 ` Takashi Iwai
2014-05-09  6:14 ` [PATCH 2/2] drm/exynos: Fix double locks " Takashi Iwai
2014-05-09  6:14   ` Takashi Iwai
2014-05-09  8:50   ` Inki Dae [this message]
2014-05-09  8:50     ` Inki Dae
2014-05-12  8:10 ` [PATCH 1/2] drm/ast: Fix double lock " Daniel Vetter
2014-05-12  8:10   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536C96CA.6000102@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.