From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-kernel@lists.codethink.co.uk
Cc: Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer
Date: Fri, 09 May 2014 10:32:33 +0100 [thread overview]
Message-ID: <536CA0B1.4040300@codethink.co.uk> (raw)
In-Reply-To: <536BFF39.40607@cogentembedded.com>
On 08/05/14 23:03, Sergei Shtylyov wrote:
> Hello.
>
> On 01/26/2014 07:05 PM, Ben Dooks wrote:
>
>> The i2c-rcar driver currently prints an error message if the master_xfer
>> callback fails. However if the bus is being probed then lots of NAKs
>> will be generated, causing the output of a number of errors printed.
>
>> To solve this, disable the print if the error is not -EREMOTEIO.
>
>> An example of running i2cdetect:
>
>> 10: i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- 12 i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>
>> Cc: Simon Horman <horms+renesas@verge.net.au>
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>> Cc: linux-i2c@vger.kernel.org
>> Cc: linux-sh@vger.kernel.org
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/i2c/busses/i2c-rcar.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/i2c/busses/i2c-rcar.c
>> b/drivers/i2c/busses/i2c-rcar.c
>> index 2c2fd7c..0d25104 100644
>> --- a/drivers/i2c/busses/i2c-rcar.c
>> +++ b/drivers/i2c/busses/i2c-rcar.c
>> @@ -623,7 +623,7 @@ static int rcar_i2c_master_xfer(struct i2c_adapter
>> *adap,
>>
>> pm_runtime_put(dev);
>>
>> - if (ret < 0)
>> + if (ret < 0 && ret != -EREMOTEIO)
>> dev_err(dev, "error %d : %x\n", ret, priv->flags);
>
> Hm, I'm now getting -EBUSY and -EAGAIN running i2cdetect on R8A7791
> base Henninger board. Only when I comment out the above 2 lines, I can
> get the bus scanned, otherwise I don't see any devices at all.
i2c-detect does not work well on the i2c-rcar due to it insisting
on sending or receiving at-least one byte of data. I think it
is possible that it confuses some of the bus devices.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-kernel@lists.codethink.co.uk
Cc: Simon Horman <horms+renesas@verge.net.au>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer
Date: Fri, 09 May 2014 09:32:33 +0000 [thread overview]
Message-ID: <536CA0B1.4040300@codethink.co.uk> (raw)
In-Reply-To: <536BFF39.40607@cogentembedded.com>
On 08/05/14 23:03, Sergei Shtylyov wrote:
> Hello.
>
> On 01/26/2014 07:05 PM, Ben Dooks wrote:
>
>> The i2c-rcar driver currently prints an error message if the master_xfer
>> callback fails. However if the bus is being probed then lots of NAKs
>> will be generated, causing the output of a number of errors printed.
>
>> To solve this, disable the print if the error is not -EREMOTEIO.
>
>> An example of running i2cdetect:
>
>> 10: i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- 12 i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>> -- i2c-rcar e6530000.i2c: error -121 : 15
>
>> Cc: Simon Horman <horms+renesas@verge.net.au>
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>> Cc: linux-i2c@vger.kernel.org
>> Cc: linux-sh@vger.kernel.org
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> drivers/i2c/busses/i2c-rcar.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/i2c/busses/i2c-rcar.c
>> b/drivers/i2c/busses/i2c-rcar.c
>> index 2c2fd7c..0d25104 100644
>> --- a/drivers/i2c/busses/i2c-rcar.c
>> +++ b/drivers/i2c/busses/i2c-rcar.c
>> @@ -623,7 +623,7 @@ static int rcar_i2c_master_xfer(struct i2c_adapter
>> *adap,
>>
>> pm_runtime_put(dev);
>>
>> - if (ret < 0)
>> + if (ret < 0 && ret != -EREMOTEIO)
>> dev_err(dev, "error %d : %x\n", ret, priv->flags);
>
> Hm, I'm now getting -EBUSY and -EAGAIN running i2cdetect on R8A7791
> base Henninger board. Only when I comment out the above 2 lines, I can
> get the bus scanned, otherwise I don't see any devices at all.
i2c-detect does not work well on the i2c-rcar due to it insisting
on sending or receiving at-least one byte of data. I think it
is possible that it confuses some of the bus devices.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-05-09 9:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390752337-22386-1-git-send-email-ben.dooks@codethink.co.uk>
2014-01-26 16:05 ` [PATCH 4/6] i2c: rcar: use devm_clk_get to ensure clock is properly ref-counted Ben Dooks
[not found] ` <1390752337-22386-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 16:05 ` [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer Ben Dooks
2014-01-26 16:05 ` Ben Dooks
[not found] ` <1390752337-22386-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-01-26 21:50 ` Wolfram Sang
2014-01-26 21:50 ` Wolfram Sang
2014-02-16 9:46 ` Wolfram Sang
2014-02-16 9:46 ` Wolfram Sang
2014-02-16 10:25 ` Geert Uytterhoeven
2014-02-16 10:25 ` Geert Uytterhoeven
2014-02-16 11:46 ` Wolfram Sang
2014-02-16 11:46 ` Wolfram Sang
2014-02-17 8:04 ` Ben Dooks
2014-05-08 22:03 ` Sergei Shtylyov
2014-05-08 22:03 ` Sergei Shtylyov
[not found] ` <536BFF39.40607-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-05-09 5:04 ` Wolfram Sang
2014-05-09 5:04 ` Wolfram Sang
2014-05-09 9:32 ` Ben Dooks [this message]
2014-05-09 9:32 ` Ben Dooks
[not found] ` <536CA0B1.4040300-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-05-09 22:55 ` Sergei Shtylyov
2014-05-09 22:55 ` Sergei Shtylyov
2014-01-26 16:05 ` [PATCH 5/6] i2c: update i2c_algorithm documentation Ben Dooks
2014-01-26 16:05 ` [PATCH 6/6] i2c: rcar: fix NACK error code Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CA0B1.4040300@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=horms+renesas@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.