All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC 1/6] omapdss: remove check for simpler port/endpoint binding
Date: Fri, 09 May 2014 09:59:53 +0000	[thread overview]
Message-ID: <536CA719.1080707@ti.com> (raw)
In-Reply-To: <1399540517-17883-1-git-send-email-archit@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On 08/05/14 12:15, Archit Taneja wrote:
> The support for simpler port/endpoint binding was removed in the merged version
> of omapdss DT. But dss_init_ports still tries to get to an endpoint even if no
> port exists. Remove this as this doesn't work.
> 
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
>  drivers/video/fbdev/omap2/dss/dss.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/dss/dss.c b/drivers/video/fbdev/omap2/dss/dss.c
> index d55266c..31ef262 100644
> --- a/drivers/video/fbdev/omap2/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/dss/dss.c
> @@ -784,12 +784,8 @@ static int __init dss_init_ports(struct platform_device *pdev)
>  		return 0;
>  
>  	port = omapdss_of_get_next_port(parent, NULL);
> -	if (!port) {
> -#ifdef CONFIG_OMAP2_DSS_DPI
> -		dpi_init_port(pdev, parent);
> -#endif
> +	if (!port)
>  		return 0;
> -	}
>  
>  	do {
>  		u32 reg;
> 

I'll try to find time to review the rest, but I'll queue this one
already for 3.16.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [RFC 1/6] omapdss: remove check for simpler port/endpoint binding
Date: Fri, 9 May 2014 12:59:53 +0300	[thread overview]
Message-ID: <536CA719.1080707@ti.com> (raw)
In-Reply-To: <1399540517-17883-1-git-send-email-archit@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

On 08/05/14 12:15, Archit Taneja wrote:
> The support for simpler port/endpoint binding was removed in the merged version
> of omapdss DT. But dss_init_ports still tries to get to an endpoint even if no
> port exists. Remove this as this doesn't work.
> 
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
>  drivers/video/fbdev/omap2/dss/dss.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/dss/dss.c b/drivers/video/fbdev/omap2/dss/dss.c
> index d55266c..31ef262 100644
> --- a/drivers/video/fbdev/omap2/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/dss/dss.c
> @@ -784,12 +784,8 @@ static int __init dss_init_ports(struct platform_device *pdev)
>  		return 0;
>  
>  	port = omapdss_of_get_next_port(parent, NULL);
> -	if (!port) {
> -#ifdef CONFIG_OMAP2_DSS_DPI
> -		dpi_init_port(pdev, parent);
> -#endif
> +	if (!port)
>  		return 0;
> -	}
>  
>  	do {
>  		u32 reg;
> 

I'll try to find time to review the rest, but I'll queue this one
already for 3.16.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-05-09  9:59 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  9:15 [RFC 1/6] omapdss: remove check for simpler port/endpoint binding Archit Taneja
2014-05-08  9:27 ` Archit Taneja
2014-05-08  9:15 ` [RFC 2/6] omapdss: add init port functions for different omap revs Archit Taneja
2014-05-08  9:27   ` Archit Taneja
2014-05-20  8:04   ` Tomi Valkeinen
2014-05-20  8:04     ` Tomi Valkeinen
2014-05-20  9:31     ` Archit Taneja
2014-05-20  9:43       ` Archit Taneja
2014-05-08  9:15 ` [RFC 3/6] omapdss: DT: Get source endpoint by matching reg-id Archit Taneja
2014-05-08  9:27   ` Archit Taneja
2014-05-08  9:15 ` [RFC 4/6] omapdss: DPI: support multiple DPI instances Archit Taneja
2014-05-08  9:27   ` Archit Taneja
2014-05-08  9:15 ` [RFC 5/6] omapdss: DPI: make dpi_get_channel take DPI reg-id Archit Taneja
2014-05-08  9:27   ` Archit Taneja
2014-05-08  9:15 ` [RFC 6/6] omapdss: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-05-08  9:27   ` Archit Taneja
2014-05-09  9:59 ` Tomi Valkeinen [this message]
2014-05-09  9:59   ` [RFC 1/6] omapdss: remove check for simpler port/endpoint binding Tomi Valkeinen
2014-05-26  9:28 ` [RFC v2 1/5] OMAPDSS: DSS: init dss ports cleanly Archit Taneja
2014-05-26  9:28   ` [RFC v2 2/5] OMAPDSS: DT: Get source endpoint by matching reg-id Archit Taneja
2014-05-27  8:34     ` Tomi Valkeinen
2014-05-27  9:49       ` Archit Taneja
2014-05-27 10:24         ` Tomi Valkeinen
2014-05-27 10:51           ` Archit Taneja
2014-05-26  9:28   ` [RFC v2 3/5] OMAPDSS: DPI: support multiple DPI instances Archit Taneja
2014-05-27  9:04     ` Tomi Valkeinen
2014-05-27  9:27       ` Archit Taneja
2014-05-26  9:28   ` [RFC v2 4/5] OMAPDSS: DPI: make dpi_get_channel take DPI reg-id Archit Taneja
2014-05-26  9:28   ` [RFC v2 5/5] OMAPDSS: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-05-27  8:24   ` [RFC v2 1/5] OMAPDSS: DSS: init dss ports cleanly Tomi Valkeinen
2014-05-27 11:42     ` Archit Taneja
2014-06-04  6:40   ` [PATCH v3 0/7] OMAPDSS: Support multiple DPI instances Archit Taneja
2014-06-04  6:52     ` Archit Taneja
2014-06-04  6:40     ` [PATCH v3 1/7] OMAPDSS: DPI: Use DPI driver data Archit Taneja
2014-06-04  6:52       ` Archit Taneja
2014-06-04  6:40     ` [PATCH v3 2/7] OMAPDSS: DPI: Allocate " Archit Taneja
2014-06-04  6:52       ` Archit Taneja
2014-06-04  6:40     ` [PATCH v3 3/7] OMAPDSS: DPI: Store dpi_data pointer in the DT port's data Archit Taneja
2014-06-04  6:52       ` Archit Taneja
2014-06-04  6:41     ` [PATCH v3 4/7] OMAPDSS: DSS: init dss ports cleanly Archit Taneja
2014-06-04  6:53       ` Archit Taneja
2014-06-26 12:16       ` Tomi Valkeinen
2014-06-26 12:16         ` Tomi Valkeinen
2014-06-04  6:41     ` [PATCH v3 5/7] OMAPDSS: DT: Get source endpoint by matching reg-id Archit Taneja
2014-06-04  6:53       ` Archit Taneja
2014-06-04  6:41     ` [PATCH v3 6/7] OMAPDSS: DPI: Add support for multiple instances Archit Taneja
2014-06-04  6:53       ` Archit Taneja
2014-06-26 12:15       ` Tomi Valkeinen
2014-06-26 12:15         ` Tomi Valkeinen
2014-06-04  6:41     ` [PATCH v3 7/7] omapdss: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-06-04  6:53       ` Archit Taneja
2014-06-26 12:28     ` [PATCH v3 0/7] OMAPDSS: Support multiple DPI instances Tomi Valkeinen
2014-06-26 12:28       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536CA719.1080707@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=archit@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.