All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Mark Brown <broonie@kernel.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	Mark Brown <broonie@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/3] arm64: Add big.LITTLE switcher stub
Date: Fri, 09 May 2014 18:05:56 +0100	[thread overview]
Message-ID: <536D0AF4.1040705@arm.com> (raw)
In-Reply-To: <1399653631-4938-2-git-send-email-broonie@kernel.org>

Hi Mark,

On 09/05/14 17:40, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The big.LITTLE cpufreq driver is useful on arm64 big.LITTLE systems even
> without IKS support since it implements support for clusters with shared
> clocks (a common big.LITTLE configuration). In order to allow it to be
> built provide the non-IKS stubs for arm64, enabling cpufreq with all the
> cores available.
>

I am in process of using this driver for ARM64 and hit the same issue.
I don't like this approach at all. I too did similar changes/hacks which are
good for quick testing but not for upstream.

I would like to move all the switcher code out of the driver as extension.
Also the core driver should be made to work with any multi-clsuter platform not
just big-little(bL). bL is one of them and bL switcher support should an
extension of it.

The main reason for this is I see some non-bL multi-cluster platform support
getting added, this driver should ideally support that.

> It may make sense to make an asm-generic version of these stubs instead but
> given that there's only likely to be these two architectures using the code
> and asm-generic stubs also need per architecture updates it's probably more
> trouble than it's worth.
>

I would not take this approach too. As mentioned above if we can resolve it in
that way we may not require this.

Regards,
Sudeep


WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm64: Add big.LITTLE switcher stub
Date: Fri, 09 May 2014 18:05:56 +0100	[thread overview]
Message-ID: <536D0AF4.1040705@arm.com> (raw)
In-Reply-To: <1399653631-4938-2-git-send-email-broonie@kernel.org>

Hi Mark,

On 09/05/14 17:40, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The big.LITTLE cpufreq driver is useful on arm64 big.LITTLE systems even
> without IKS support since it implements support for clusters with shared
> clocks (a common big.LITTLE configuration). In order to allow it to be
> built provide the non-IKS stubs for arm64, enabling cpufreq with all the
> cores available.
>

I am in process of using this driver for ARM64 and hit the same issue.
I don't like this approach at all. I too did similar changes/hacks which are
good for quick testing but not for upstream.

I would like to move all the switcher code out of the driver as extension.
Also the core driver should be made to work with any multi-clsuter platform not
just big-little(bL). bL is one of them and bL switcher support should an
extension of it.

The main reason for this is I see some non-bL multi-cluster platform support
getting added, this driver should ideally support that.

> It may make sense to make an asm-generic version of these stubs instead but
> given that there's only likely to be these two architectures using the code
> and asm-generic stubs also need per architecture updates it's probably more
> trouble than it's worth.
>

I would not take this approach too. As mentioned above if we can resolve it in
that way we may not require this.

Regards,
Sudeep

  reply	other threads:[~2014-05-09 17:04 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 16:40 [PATCH 1/3] arm64: Enable OPP Mark Brown
2014-05-09 16:40 ` Mark Brown
2014-05-09 16:40 ` [PATCH 2/3] arm64: Add big.LITTLE switcher stub Mark Brown
2014-05-09 16:40   ` Mark Brown
2014-05-09 17:05   ` Sudeep Holla [this message]
2014-05-09 17:05     ` Sudeep Holla
2014-05-09 17:50     ` Mark Brown
2014-05-09 17:50       ` Mark Brown
2014-05-09 18:57       ` Sudeep Holla
2014-05-09 18:57         ` Sudeep Holla
2014-05-09 19:29         ` Mark Brown
2014-05-09 19:29           ` Mark Brown
2014-05-12  8:34           ` Sudeep Holla
2014-05-12  8:34             ` Sudeep Holla
2014-05-12 12:17             ` Mark Brown
2014-05-12 12:17               ` Mark Brown
2014-05-12 14:09               ` Mark Hambleton
2014-05-12 14:09                 ` Mark Hambleton
2014-05-09 17:47   ` Catalin Marinas
2014-05-09 17:47     ` Catalin Marinas
2014-05-09 18:01     ` Mark Brown
2014-05-09 18:01       ` Mark Brown
2014-05-11  3:29       ` Nicolas Pitre
2014-05-11  3:29         ` Nicolas Pitre
2014-05-09 16:40 ` [PATCH 3/3] cpufreq: Enable big.LITTLE cpufreq driver on arm64 Mark Brown
2014-05-09 16:40   ` Mark Brown
2014-05-12  4:16   ` Viresh Kumar
2014-05-12  4:16     ` Viresh Kumar
2014-05-19 23:19     ` Rafael J. Wysocki
2014-05-19 23:19       ` Rafael J. Wysocki
2014-05-19 23:07       ` Mark Brown
2014-05-19 23:07         ` Mark Brown
2014-05-19 23:36         ` Rafael J. Wysocki
2014-05-19 23:36           ` Rafael J. Wysocki
2014-06-05 10:04           ` Catalin Marinas
2014-06-05 10:04             ` Catalin Marinas
2014-06-05 12:10             ` Rafael J. Wysocki
2014-06-05 12:10               ` Rafael J. Wysocki
2014-05-09 17:02 ` [PATCH 1/3] arm64: Enable OPP menon.nishanth
2014-05-09 17:02   ` menon.nishanth at gmail.com
2014-05-09 17:11   ` Mark Brown
2014-05-09 17:11     ` Mark Brown
2014-05-09 17:17     ` menon.nishanth
2014-05-09 17:17       ` menon.nishanth at gmail.com
2014-05-09 18:18       ` Mark Brown
2014-05-09 18:18         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536D0AF4.1040705@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.