All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>,
	Pekka Enberg <penberg@kernel.org>
Cc: David Daney <ddaney.cavm@gmail.com>, <kvm@vger.kernel.org>,
	<linux-mips@linux-mips.org>, David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 06/11] kvm tools, mips: Enable build of mips support
Date: Fri, 9 May 2014 22:22:15 +0100	[thread overview]
Message-ID: <536D4707.5090207@imgtec.com> (raw)
In-Reply-To: <1399391491-5021-7-git-send-email-andreas.herrmann@caviumnetworks.com>

Hi Andreas,

On 06/05/14 16:51, Andreas Herrmann wrote:
> From: David Daney <david.daney@cavium.com>
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> Signed-off-by: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
> ---
>  tools/kvm/Makefile |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
> index b872651..91286ad 100644
> --- a/tools/kvm/Makefile
> +++ b/tools/kvm/Makefile
> @@ -105,7 +105,7 @@ OBJS	+= virtio/mmio.o
>  
>  # Translate uname -m into ARCH string
>  ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \
> -	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/)
> +	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
>  
>  ifeq ($(ARCH),i386)
>  	ARCH         := x86
> @@ -184,6 +184,15 @@ ifeq ($(ARCH), arm64)
>  	ARCH_WANT_LIBFDT := y
>  endif
>  
> +ifeq ($(ARCH),mips)
> +	DEFINES		+= -DCONFIG_MIPS
> +	ARCH_INCLUDE	:= mips/include
> +	CFLAGS		+= -I../../arch/mips/include/asm/mach-cavium-octeon
> +	CFLAGS		+= -I../../arch/mips/include/asm/mach-generic

I can't see any obvious includes from these two directories in the
previous patch. Are there any?

> +	OBJS		+= mips/kvm.o
> +	OBJS		+= mips/kvm-cpu.o
> +	OBJS		+= mips/irq.o
> +endif
>  ###
>  
>  ifeq (,$(ARCH_INCLUDE))
> 

Cheers
James

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>,
	Pekka Enberg <penberg@kernel.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
	kvm@vger.kernel.org, linux-mips@linux-mips.org,
	David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 06/11] kvm tools, mips: Enable build of mips support
Date: Fri, 9 May 2014 22:22:15 +0100	[thread overview]
Message-ID: <536D4707.5090207@imgtec.com> (raw)
Message-ID: <20140509212215.87kSOMGUzM8RfWwJyKybFe9WBF1Tiv74OEoDrg4Tbb8@z> (raw)
In-Reply-To: <1399391491-5021-7-git-send-email-andreas.herrmann@caviumnetworks.com>

Hi Andreas,

On 06/05/14 16:51, Andreas Herrmann wrote:
> From: David Daney <david.daney@cavium.com>
> 
> Signed-off-by: David Daney <david.daney@cavium.com>
> Signed-off-by: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
> ---
>  tools/kvm/Makefile |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/kvm/Makefile b/tools/kvm/Makefile
> index b872651..91286ad 100644
> --- a/tools/kvm/Makefile
> +++ b/tools/kvm/Makefile
> @@ -105,7 +105,7 @@ OBJS	+= virtio/mmio.o
>  
>  # Translate uname -m into ARCH string
>  ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \
> -	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/)
> +	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
>  
>  ifeq ($(ARCH),i386)
>  	ARCH         := x86
> @@ -184,6 +184,15 @@ ifeq ($(ARCH), arm64)
>  	ARCH_WANT_LIBFDT := y
>  endif
>  
> +ifeq ($(ARCH),mips)
> +	DEFINES		+= -DCONFIG_MIPS
> +	ARCH_INCLUDE	:= mips/include
> +	CFLAGS		+= -I../../arch/mips/include/asm/mach-cavium-octeon
> +	CFLAGS		+= -I../../arch/mips/include/asm/mach-generic

I can't see any obvious includes from these two directories in the
previous patch. Are there any?

> +	OBJS		+= mips/kvm.o
> +	OBJS		+= mips/kvm-cpu.o
> +	OBJS		+= mips/irq.o
> +endif
>  ###
>  
>  ifeq (,$(ARCH_INCLUDE))
> 

Cheers
James

  reply	other threads:[~2014-05-09 21:22 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 15:51 [PATCH 00/11] kvm tools: Misc patches (mips support) Andreas Herrmann
2014-05-06 15:51 ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 01/11] kvm tools: Print message on failure of KVM_CREATE_VM Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 02/11] kvm tools: Fix print format warnings Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 03/11] kvm tools: Move definition of TERM_MAX_DEVS to header Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 04/11] kvm tools: Allow to load ELF binary Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 05/11] kvm tools, mips: Add MIPS support Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-09 21:15   ` James Hogan
2014-05-09 21:15     ` James Hogan
2014-05-12 13:01     ` Andreas Herrmann
2014-05-12 14:09       ` James Hogan
2014-05-12 14:09         ` James Hogan
2014-05-19 13:37         ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 06/11] kvm tools, mips: Enable build of mips support Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-09 21:22   ` James Hogan [this message]
2014-05-09 21:22     ` James Hogan
2014-05-12 10:46     ` Andreas Herrmann
2014-05-12 10:46       ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 07/11] kvm tools: Provide per arch macro to specify type for KVM_CREATE_VM Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-09 21:34   ` James Hogan
2014-05-09 21:34     ` James Hogan
2014-05-12 10:46     ` Andreas Herrmann
2014-05-12 10:46       ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 08/11] kvm tools: Handle virtio/pci I/O space as little endian Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 09/11] kvm tools, mips: Add support for loading elf binaries Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 10/11] kvm tools: Introduce weak (default) load_bzimage function Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-09 21:44   ` James Hogan
2014-05-09 21:44     ` James Hogan
2014-05-12 10:47     ` Andreas Herrmann
2014-05-12 10:47       ` Andreas Herrmann
2014-05-06 15:51 ` [PATCH 11/11] kvm tools: Modify term_putc to write more than one char Andreas Herrmann
2014-05-06 15:51   ` Andreas Herrmann
2014-05-07 15:58   ` Sergei Shtylyov
2014-05-12 11:21     ` Andreas Herrmann
2014-05-12 11:21       ` Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536D4707.5090207@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=andreas.herrmann@caviumnetworks.com \
    --cc=david.daney@cavium.com \
    --cc=ddaney.cavm@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.