* [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks
@ 2014-05-09 6:01 Suresh Thiagarajan
2014-05-10 19:04 ` Tomas Henzl
2014-05-12 8:08 ` Jack Wang
0 siblings, 2 replies; 3+ messages in thread
From: Suresh Thiagarajan @ 2014-05-09 6:01 UTC (permalink / raw)
To: linux-scsi
Cc: xjtuwjp, JBottomley, Vasanthalakshmi.Tharmarajan,
Suresh.Thiagarajan, Viswas.G
Checking return value for the memory allocattion and freeing it
while exiting the function
Signed-off-by: Viswas G <Viswas.G@pmcs.com>
Signed-off-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
---
drivers/scsi/pm8001/pm8001_ctl.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
index 28b4e81..5f68571 100644
--- a/drivers/scsi/pm8001/pm8001_ctl.c
+++ b/drivers/scsi/pm8001/pm8001_ctl.c
@@ -395,6 +395,8 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
payload.offset = 0;
payload.length = 4096;
payload.func_specific = kzalloc(4096, GFP_KERNEL);
+ if (!payload.func_specific)
+ return -ENOMEM;
PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
wait_for_completion(&completion);
virt_addr = pm8001_ha->memoryMap.region[NVMD].virt_ptr;
@@ -402,6 +404,7 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
bios_index++)
str += sprintf(str, "%c",
*((u8 *)((u8 *)virt_addr+bios_index)));
+ kfree(payload.func_specific);
return str - buf;
}
static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show, NULL);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks
2014-05-09 6:01 [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks Suresh Thiagarajan
@ 2014-05-10 19:04 ` Tomas Henzl
2014-05-12 8:08 ` Jack Wang
1 sibling, 0 replies; 3+ messages in thread
From: Tomas Henzl @ 2014-05-10 19:04 UTC (permalink / raw)
To: Suresh Thiagarajan, linux-scsi
Cc: xjtuwjp, JBottomley, Vasanthalakshmi.Tharmarajan, Viswas.G
On 05/09/2014 08:01 AM, Suresh Thiagarajan wrote:
> Checking return value for the memory allocattion and freeing it
> while exiting the function
The fix seems fine to me.
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
>
> Signed-off-by: Viswas G <Viswas.G@pmcs.com>
> Signed-off-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index 28b4e81..5f68571 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -395,6 +395,8 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
> payload.offset = 0;
> payload.length = 4096;
> payload.func_specific = kzalloc(4096, GFP_KERNEL);
> + if (!payload.func_specific)
> + return -ENOMEM;
> PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
> wait_for_completion(&completion);
> virt_addr = pm8001_ha->memoryMap.region[NVMD].virt_ptr;
> @@ -402,6 +404,7 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
> bios_index++)
> str += sprintf(str, "%c",
> *((u8 *)((u8 *)virt_addr+bios_index)));
> + kfree(payload.func_specific);
> return str - buf;
> }
> static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show, NULL);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks
2014-05-09 6:01 [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks Suresh Thiagarajan
2014-05-10 19:04 ` Tomas Henzl
@ 2014-05-12 8:08 ` Jack Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jack Wang @ 2014-05-12 8:08 UTC (permalink / raw)
To: Suresh Thiagarajan
Cc: linux-scsi, JBottomley, Vasanthalakshmi.Tharmarajan, Viswas.G
On 05/09/2014 08:01 AM, Suresh Thiagarajan wrote:
> Checking return value for the memory allocattion and freeing it
> while exiting the function
>
> Signed-off-by: Viswas G <Viswas.G@pmcs.com>
> Signed-off-by: Suresh Thiagarajan <Suresh.Thiagarajan@pmcs.com>
> ---
> drivers/scsi/pm8001/pm8001_ctl.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_ctl.c b/drivers/scsi/pm8001/pm8001_ctl.c
> index 28b4e81..5f68571 100644
> --- a/drivers/scsi/pm8001/pm8001_ctl.c
> +++ b/drivers/scsi/pm8001/pm8001_ctl.c
> @@ -395,6 +395,8 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
> payload.offset = 0;
> payload.length = 4096;
> payload.func_specific = kzalloc(4096, GFP_KERNEL);
> + if (!payload.func_specific)
> + return -ENOMEM;
> PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
> wait_for_completion(&completion);
> virt_addr = pm8001_ha->memoryMap.region[NVMD].virt_ptr;
> @@ -402,6 +404,7 @@ static ssize_t pm8001_ctl_bios_version_show(struct device *cdev,
> bios_index++)
> str += sprintf(str, "%c",
> *((u8 *)((u8 *)virt_addr+bios_index)));
> + kfree(payload.func_specific);
> return str - buf;
> }
> static DEVICE_ATTR(bios_version, S_IRUGO, pm8001_ctl_bios_version_show, NULL);
>
Thanks, looks good.
Acked-by: Jack Wang <xjtuwjp@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-09 6:01 [PATCH] pm80xx : Fix missing NULL pointer checks and memory leaks Suresh Thiagarajan
2014-05-10 19:04 ` Tomas Henzl
2014-05-12 8:08 ` Jack Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.