From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset
Date: Mon, 12 May 2014 11:12:16 +0200 [thread overview]
Message-ID: <53709070.9080706@redhat.com> (raw)
In-Reply-To: <53707E00.4000908@suse.de>
Il 12/05/2014 09:53, Andreas Färber ha scritto:
>> > Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset.
>> > These only reset the CPU.
>> >
>> > Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Apart from the question of whether cpu_soft_reset() is the right API for
> this: Does this result in guest-visible changes that we need to suppress
> for previous machine types?
The changes can be considered bug fixes. If anything did rely on INIT
signals resetting nothing but the CPU (for example old 16-bit code that
wanted to get out of protected mode), it would be broken without these
changes.
Paolo
next prev parent reply other threads:[~2014-05-12 9:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 14:33 [Qemu-devel] [PATCH v2 0/8] x86: correctly implement soft reset Paolo Bonzini
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 1/8] kvm: reset state from the CPU's reset method Paolo Bonzini
2014-05-12 7:15 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 2/8] kvm: forward INIT signals coming from the chipset Paolo Bonzini
2014-05-12 7:59 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 3/8] target-i386: fix set of registers zeroed on reset Paolo Bonzini
2014-05-12 7:56 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 4/8] target-i386: preserve FPU and MSR state on INIT Paolo Bonzini
2014-05-12 7:23 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 5/8] apic: do not accept SIPI on the bootstrap processor Paolo Bonzini
2014-05-12 7:36 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 6/8] cpu: make CPU_INTERRUPT_RESET available on all targets Paolo Bonzini
2014-05-12 7:47 ` Andreas Färber
2014-05-12 9:41 ` Peter Maydell
2014-05-12 10:31 ` Paolo Bonzini
2014-05-23 17:59 ` Peter Maydell
2014-05-23 18:10 ` Paolo Bonzini
2014-05-24 8:30 ` Peter Maydell
2014-05-24 12:59 ` Paolo Bonzini
2014-05-24 15:54 ` Peter Maydell
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 7/8] pc: port 92 reset requires a low->high transition Paolo Bonzini
2014-05-12 7:48 ` Andreas Färber
2014-05-02 14:33 ` [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset Paolo Bonzini
2014-05-05 12:13 ` Michael S. Tsirkin
2014-05-12 7:53 ` Andreas Färber
2014-05-12 9:12 ` Paolo Bonzini [this message]
2014-05-05 12:11 ` [Qemu-devel] [PATCH v2 0/8] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53709070.9080706@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.