From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: replace devm_kzalloc() with devm_kmalloc()
Date: Mon, 12 May 2014 11:52:20 +0000 [thread overview]
Message-ID: <5370B5F4.6020901@cogentembedded.com> (raw)
In-Reply-To: <1399853435.9156.1.camel@joe-AO725>
Hello.
On 05/12/2014 04:10 AM, Joe Perches wrote:
>> Now that devm_kmalloc() has become available, we can avoid the needless
>> zeroing out of the PHY IRQ array.
> []
>> net-next/drivers/net/ethernet/renesas/sh_eth.c
> []
>> @@ -2627,7 +2627,7 @@ static int sh_mdio_init(struct sh_eth_pr
> []
>> - mdp->mii_bus->irq = devm_kzalloc(dev, sizeof(int) * PHY_MAX_ADDR,
>> + mdp->mii_bus->irq = devm_kmalloc(dev, sizeof(int) * PHY_MAX_ADDR,
> perhaps
> mdp->mii_bus->irq = devm_kmalloc_array(dev, PHY_MAX_ADDR, sizeof(int),
Yes, that has occurred to me after I sent the patch...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh_eth: replace devm_kzalloc() with devm_kmalloc()
Date: Mon, 12 May 2014 15:52:20 +0400 [thread overview]
Message-ID: <5370B5F4.6020901@cogentembedded.com> (raw)
In-Reply-To: <1399853435.9156.1.camel@joe-AO725>
Hello.
On 05/12/2014 04:10 AM, Joe Perches wrote:
>> Now that devm_kmalloc() has become available, we can avoid the needless
>> zeroing out of the PHY IRQ array.
> []
>> net-next/drivers/net/ethernet/renesas/sh_eth.c
> []
>> @@ -2627,7 +2627,7 @@ static int sh_mdio_init(struct sh_eth_pr
> []
>> - mdp->mii_bus->irq = devm_kzalloc(dev, sizeof(int) * PHY_MAX_ADDR,
>> + mdp->mii_bus->irq = devm_kmalloc(dev, sizeof(int) * PHY_MAX_ADDR,
> perhaps
> mdp->mii_bus->irq = devm_kmalloc_array(dev, PHY_MAX_ADDR, sizeof(int),
Yes, that has occurred to me after I sent the patch...
WBR, Sergei
next prev parent reply other threads:[~2014-05-12 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 20:05 [PATCH] sh_eth: replace devm_kzalloc() with devm_kmalloc() Sergei Shtylyov
2014-05-11 20:05 ` Sergei Shtylyov
2014-05-12 0:10 ` Joe Perches
2014-05-12 0:10 ` Joe Perches
2014-05-12 11:52 ` Sergei Shtylyov [this message]
2014-05-12 11:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370B5F4.6020901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=joe@perches.com \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.