From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
Date: Mon, 12 May 2014 16:25:36 +0200 [thread overview]
Message-ID: <5370D9E0.4000509@free-electrons.com> (raw)
In-Reply-To: <1399904532-3688-1-git-send-email-alexandre.belloni@free-electrons.com>
On 12/05/2014 16:22, Alexandre Belloni wrote:
> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
> Also, the at91sam9261 doesn't really have a by 3 divisor.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changed in v2:
> After getting feedback from the atmel HW engineers, it appears that PLLB is not
> the same as PLLA despite what the datasheet seems to imply. The patch is updated
> to reflect that.
>
> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> index 561addceb81e..44d9e5ab09c3 100644
> --- a/arch/arm/boot/dts/at91sam9261.dtsi
> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
> @@ -564,7 +564,8 @@
> reg = <0>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> pllb: pllbck {
> @@ -573,9 +574,9 @@
> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
> clocks = <&main>;
> reg = <1>;
> - atmel,clk-input-range = <1000000 32000000>;
> + atmel,clk-input-range = <1000000 5000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
> };
>
> mck: masterck {
> @@ -584,13 +585,13 @@
> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
> atmel,clk-output-range = <0 94000000>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> };
>
> usb: usbck {
> compatible = "atmel,at91rm9200-clk-usb";
> #clock-cells = <0>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> clocks = <&pllb>;
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors
Date: Mon, 12 May 2014 16:25:36 +0200 [thread overview]
Message-ID: <5370D9E0.4000509@free-electrons.com> (raw)
In-Reply-To: <1399904532-3688-1-git-send-email-alexandre.belloni@free-electrons.com>
On 12/05/2014 16:22, Alexandre Belloni wrote:
> Argument 3 (OUT) and 4 (ICPLL) of the atmel,pll-clk-output-ranges were missing.
> Also, the at91sam9261 doesn't really have a by 3 divisor.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changed in v2:
> After getting feedback from the atmel HW engineers, it appears that PLLB is not
> the same as PLLA despite what the datasheet seems to imply. The patch is updated
> to reflect that.
>
> arch/arm/boot/dts/at91sam9261.dtsi | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
> index 561addceb81e..44d9e5ab09c3 100644
> --- a/arch/arm/boot/dts/at91sam9261.dtsi
> +++ b/arch/arm/boot/dts/at91sam9261.dtsi
> @@ -564,7 +564,8 @@
> reg = <0>;
> atmel,clk-input-range = <1000000 32000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <80000000 200000000 0 1>,
> + <190000000 240000000 2 1>;
> };
>
> pllb: pllbck {
> @@ -573,9 +574,9 @@
> interrupts-extended = <&pmc AT91_PMC_LOCKB>;
> clocks = <&main>;
> reg = <1>;
> - atmel,clk-input-range = <1000000 32000000>;
> + atmel,clk-input-range = <1000000 5000000>;
> #atmel,pll-clk-output-range-cells = <4>;
> - atmel,pll-clk-output-ranges = <80000000 200000000 190000000 240000000>;
> + atmel,pll-clk-output-ranges = <70000000 130000000 1 1>;
> };
>
> mck: masterck {
> @@ -584,13 +585,13 @@
> interrupts-extended = <&pmc AT91_PMC_MCKRDY>;
> clocks = <&clk32k>, <&main>, <&plla>, <&pllb>;
> atmel,clk-output-range = <0 94000000>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> };
>
> usb: usbck {
> compatible = "atmel,at91rm9200-clk-usb";
> #clock-cells = <0>;
> - atmel,clk-divisors = <1 2 4 3>;
> + atmel,clk-divisors = <1 2 4 0>;
> clocks = <&pllb>;
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-05-12 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 14:22 [PATCHv2] ARM: at91/dt: sam9261: Fix PLL output ranges and other clocks divisors Alexandre Belloni
2014-05-12 14:22 ` Alexandre Belloni
2014-05-12 14:25 ` Boris BREZILLON [this message]
2014-05-12 14:25 ` Boris BREZILLON
2014-05-12 14:54 ` Nicolas Ferre
2014-05-12 14:54 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5370D9E0.4000509@free-electrons.com \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.