From: Guenter Roeck <linux@roeck-us.net>
To: Josef Gajdusek <atx@atx.name>
Cc: jdelvare@suse.de, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 0/9] hwmon: (emc1403) Various enhancements
Date: Tue, 13 May 2014 01:02:27 +0000 [thread overview]
Message-ID: <53716F23.4010704@roeck-us.net> (raw)
In-Reply-To: <20140512210801.GA7839@dashie>
On 05/12/2014 02:08 PM, Josef Gajdusek wrote:
> Had to fix wrong variable being printed in show_bit(). After that, everything on the 1412 seems to work fine including alarms.
>
> - return sprintf(buf, "%d\n", !!(retval & sda->index));
> + return sprintf(buf, "%d\n", !!(val & sda->index));
>
>
Hi Josef,
Fixed with v2. Thanks a lot for the feedback!
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Josef Gajdusek <atx@atx.name>
Cc: jdelvare@suse.de, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] hwmon: (emc1403) Various enhancements
Date: Mon, 12 May 2014 18:02:27 -0700 [thread overview]
Message-ID: <53716F23.4010704@roeck-us.net> (raw)
In-Reply-To: <20140512210801.GA7839@dashie>
On 05/12/2014 02:08 PM, Josef Gajdusek wrote:
> Had to fix wrong variable being printed in show_bit(). After that, everything on the 1412 seems to work fine including alarms.
>
> - return sprintf(buf, "%d\n", !!(retval & sda->index));
> + return sprintf(buf, "%d\n", !!(val & sda->index));
>
>
Hi Josef,
Fixed with v2. Thanks a lot for the feedback!
Guenter
next prev parent reply other threads:[~2014-05-13 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 19:01 [lm-sensors] [PATCH 0/9] hwmon: (emc1403) Various enhancements Guenter Roeck
2014-05-12 21:08 ` Josef Gajdusek
2014-05-12 21:08 ` Josef Gajdusek
2014-05-13 1:02 ` Guenter Roeck [this message]
2014-05-13 1:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53716F23.4010704@roeck-us.net \
--to=linux@roeck-us.net \
--cc=atx@atx.name \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.