* [PATCH net-next] dccp: make the request_retries minimum is 1
@ 2014-05-13 2:57 ` Wang Weidong
0 siblings, 0 replies; 6+ messages in thread
From: Wang Weidong @ 2014-05-13 2:57 UTC (permalink / raw)
To: dccp
In Documentation/networking/dccp.txt points that request_retries
should be greater than 0. So make the extra1 to be &one instead
of &zero.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/dccp/sysctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
index 607ab71..53731e4 100644
--- a/net/dccp/sysctl.c
+++ b/net/dccp/sysctl.c
@@ -20,6 +20,7 @@
/* Boundary values */
static int zero = 0,
+ one = 1,
u8_max = 0xFF;
static unsigned long seqw_min = DCCPF_SEQ_WMIN,
seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */
@@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
.maxlen = sizeof(sysctl_dccp_request_retries),
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
- .extra1 = &zero,
+ .extra1 = &one,
.extra2 = &u8_max,
},
{
--
1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net-next] dccp: make the request_retries minimum is 1
@ 2014-05-13 2:57 ` Wang Weidong
0 siblings, 0 replies; 6+ messages in thread
From: Wang Weidong @ 2014-05-13 2:57 UTC (permalink / raw)
To: David Miller, Gerrit Renker; +Cc: dccp, netdev
In Documentation/networking/dccp.txt points that request_retries
should be greater than 0. So make the extra1 to be &one instead
of &zero.
Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
net/dccp/sysctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
index 607ab71..53731e4 100644
--- a/net/dccp/sysctl.c
+++ b/net/dccp/sysctl.c
@@ -20,6 +20,7 @@
/* Boundary values */
static int zero = 0,
+ one = 1,
u8_max = 0xFF;
static unsigned long seqw_min = DCCPF_SEQ_WMIN,
seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */
@@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
.maxlen = sizeof(sysctl_dccp_request_retries),
.mode = 0644,
.proc_handler = proc_dointvec_minmax,
- .extra1 = &zero,
+ .extra1 = &one,
.extra2 = &u8_max,
},
{
--
1.7.12
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] dccp: make the request_retries minimum is 1
2014-05-13 2:57 ` Wang Weidong
@ 2014-05-14 10:01 ` Gerrit Renker
-1 siblings, 0 replies; 6+ messages in thread
From: Gerrit Renker @ 2014-05-14 10:01 UTC (permalink / raw)
To: dccp
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> ---
> net/dccp/sysctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
> index 607ab71..53731e4 100644
> --- a/net/dccp/sysctl.c
> +++ b/net/dccp/sysctl.c
> @@ -20,6 +20,7 @@
>
> /* Boundary values */
> static int zero = 0,
> + one = 1,
> u8_max = 0xFF;
> static unsigned long seqw_min = DCCPF_SEQ_WMIN,
> seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */
> @@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
> .maxlen = sizeof(sysctl_dccp_request_retries),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> - .extra1 = &zero,
> + .extra1 = &one,
> .extra2 = &u8_max,
> },
> {
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] dccp: make the request_retries minimum is 1
@ 2014-05-14 10:01 ` Gerrit Renker
0 siblings, 0 replies; 6+ messages in thread
From: Gerrit Renker @ 2014-05-14 10:01 UTC (permalink / raw)
To: Wang Weidong; +Cc: David Miller, dccp, netdev
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> ---
> net/dccp/sysctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c
> index 607ab71..53731e4 100644
> --- a/net/dccp/sysctl.c
> +++ b/net/dccp/sysctl.c
> @@ -20,6 +20,7 @@
>
> /* Boundary values */
> static int zero = 0,
> + one = 1,
> u8_max = 0xFF;
> static unsigned long seqw_min = DCCPF_SEQ_WMIN,
> seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */
> @@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = {
> .maxlen = sizeof(sysctl_dccp_request_retries),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> - .extra1 = &zero,
> + .extra1 = &one,
> .extra2 = &u8_max,
> },
> {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dccp: make the request_retries minimum is 1
2014-05-13 2:57 ` Wang Weidong
@ 2014-05-14 19:34 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-05-14 19:34 UTC (permalink / raw)
To: dccp
From: Wang Weidong <wangweidong1@huawei.com>
Date: Tue, 13 May 2014 10:57:58 +0800
> In Documentation/networking/dccp.txt points that request_retries
> should be greater than 0. So make the extra1 to be &one instead
> of &zero.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] dccp: make the request_retries minimum is 1
@ 2014-05-14 19:34 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2014-05-14 19:34 UTC (permalink / raw)
To: wangweidong1; +Cc: gerrit, dccp, netdev
From: Wang Weidong <wangweidong1@huawei.com>
Date: Tue, 13 May 2014 10:57:58 +0800
> In Documentation/networking/dccp.txt points that request_retries
> should be greater than 0. So make the extra1 to be &one instead
> of &zero.
>
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-14 19:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 2:57 [PATCH net-next] dccp: make the request_retries minimum is 1 Wang Weidong
2014-05-13 2:57 ` Wang Weidong
2014-05-14 10:01 ` Gerrit Renker
2014-05-14 10:01 ` Gerrit Renker
2014-05-14 19:34 ` David Miller
2014-05-14 19:34 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.