From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control"
Date: Tue, 13 May 2014 11:51:51 +0800 [thread overview]
Message-ID: <537196D7.3020302@huawei.com> (raw)
In-Reply-To: <1399663975-315-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 35daf89..b81e7c0 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -2542,11 +2542,13 @@ static int cgroup_subtree_control_write(struct cgroup_subsys_state *dummy_css,
> int ssid, ret;
>
> /*
> - * Parse input - white space separated list of subsystem names
> - * prefixed with either + or -.
> + * Parse input - space separated list of subsystem names prefixed
> + * with either + or -.
> */
> p = buffer;
> - while ((tok = strsep(&p, " \t\n"))) {
> + while ((tok = strsep(&p, " "))) {
> + if (tok[0] =='\0')
if (tok[0] == '\0')
> + continue;
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control"
Date: Tue, 13 May 2014 11:51:51 +0800 [thread overview]
Message-ID: <537196D7.3020302@huawei.com> (raw)
In-Reply-To: <1399663975-315-5-git-send-email-tj@kernel.org>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 35daf89..b81e7c0 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -2542,11 +2542,13 @@ static int cgroup_subtree_control_write(struct cgroup_subsys_state *dummy_css,
> int ssid, ret;
>
> /*
> - * Parse input - white space separated list of subsystem names
> - * prefixed with either + or -.
> + * Parse input - space separated list of subsystem names prefixed
> + * with either + or -.
> */
> p = buffer;
> - while ((tok = strsep(&p, " \t\n"))) {
> + while ((tok = strsep(&p, " "))) {
> + if (tok[0] =='\0')
if (tok[0] == '\0')
> + continue;
next prev parent reply other threads:[~2014-05-13 3:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 19:32 [PATCHSET v2 cgroup/for-3.16] cgroup: post unified hierarchy fixes and updates Tejun Heo
2014-05-09 19:32 ` [PATCH 1/7] cgroup: fix offlining child waiting in cgroup_subtree_control_write() Tejun Heo
2014-05-09 19:32 ` [PATCH 2/7] cgroup: cgroup_idr_lock should be bh Tejun Heo
2014-05-09 19:32 ` [PATCH 3/7] cgroup: css_release() shouldn't clear cgroup->subsys[] Tejun Heo
2014-05-09 19:32 ` [PATCH 4/7] cgroup: update and fix parsing of "cgroup.subtree_control" Tejun Heo
[not found] ` <1399663975-315-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-13 3:51 ` Li Zefan [this message]
2014-05-13 3:51 ` Li Zefan
[not found] ` <537196D7.3020302-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-05-13 15:18 ` Tejun Heo
2014-05-13 15:18 ` Tejun Heo
2014-05-09 19:32 ` [PATCH 5/7] cgroup: use restart_syscall() for retries after offline waits in cgroup_subtree_control_write() Tejun Heo
[not found] ` <1399663975-315-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-13 5:00 ` Li Zefan
2014-05-13 5:00 ` Li Zefan
[not found] ` <5371A6DB.2050908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-05-13 15:19 ` Tejun Heo
2014-05-13 15:19 ` Tejun Heo
2014-05-09 19:32 ` [PATCH 6/7] cgroup: use release_agent_path_lock in cgroup_release_agent_show() Tejun Heo
2014-05-09 19:32 ` [PATCH 7/7] cgroup: rename css_tryget*() to css_tryget_online*() Tejun Heo
[not found] ` <1399663975-315-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-09 19:47 ` [PATCH v2 " Tejun Heo
2014-05-09 19:47 ` Tejun Heo
[not found] ` <1399663975-315-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-13 6:35 ` [PATCHSET v2 cgroup/for-3.16] cgroup: post unified hierarchy fixes and updates Li Zefan
2014-05-13 6:35 ` Li Zefan
2014-05-13 16:12 ` Tejun Heo
2014-05-13 16:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537196D7.3020302@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.