From: Paolo Bonzini <pbonzini@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-trivial] [PATCH 2/2] nbd: Miscellaneous typo fixes.
Date: Tue, 13 May 2014 11:08:09 +0200 [thread overview]
Message-ID: <5371E0F9.3030105@redhat.com> (raw)
In-Reply-To: <1399937716-6086-2-git-send-email-kroosec@gmail.com>
Il 13/05/2014 01:35, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> nbd.c | 2 +-
> qemu-nbd.c | 2 +-
> qemu-nbd.texi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/nbd.c b/nbd.c
> index e5084b6..e0d032c 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -306,7 +306,7 @@ static int nbd_send_negotiate(NBDClient *client)
> [ 8 .. 15] magic (NBD_CLIENT_MAGIC)
> [16 .. 23] size
> [24 .. 25] server flags (0)
> - [24 .. 27] export flags
> + [26 .. 27] export flags
> [28 .. 151] reserved (0)
>
> Negotiation header with options, part 1:
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index f70e4b0..cd6bd50 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -294,7 +294,7 @@ static void *nbd_client_thread(void *arg)
> fd = open(device, O_RDWR);
> if (fd < 0) {
> /* Linux-only, we can use %m in printf. */
> - fprintf(stderr, "Failed to open %s: %m", device);
> + fprintf(stderr, "Failed to open %s: %m\n", device);
> goto out_socket;
> }
>
> diff --git a/qemu-nbd.texi b/qemu-nbd.texi
> index 0a7e013..46fd483 100644
> --- a/qemu-nbd.texi
> +++ b/qemu-nbd.texi
> @@ -15,7 +15,7 @@ Export QEMU disk image using NBD protocol.
> @item @var{filename}
> is a disk image filename
> @item -p, --port=@var{port}
> - port to listen on (default @samp{1024})
> + port to listen on (default @samp{10809})
> @item -o, --offset=@var{offset}
> offset into the image
> @item -b, --bind=@var{iface}
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] nbd: Miscellaneous typo fixes.
Date: Tue, 13 May 2014 11:08:09 +0200 [thread overview]
Message-ID: <5371E0F9.3030105@redhat.com> (raw)
In-Reply-To: <1399937716-6086-2-git-send-email-kroosec@gmail.com>
Il 13/05/2014 01:35, Hani Benhabiles ha scritto:
> Signed-off-by: Hani Benhabiles <hani@linux.com>
> ---
> nbd.c | 2 +-
> qemu-nbd.c | 2 +-
> qemu-nbd.texi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/nbd.c b/nbd.c
> index e5084b6..e0d032c 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -306,7 +306,7 @@ static int nbd_send_negotiate(NBDClient *client)
> [ 8 .. 15] magic (NBD_CLIENT_MAGIC)
> [16 .. 23] size
> [24 .. 25] server flags (0)
> - [24 .. 27] export flags
> + [26 .. 27] export flags
> [28 .. 151] reserved (0)
>
> Negotiation header with options, part 1:
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index f70e4b0..cd6bd50 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -294,7 +294,7 @@ static void *nbd_client_thread(void *arg)
> fd = open(device, O_RDWR);
> if (fd < 0) {
> /* Linux-only, we can use %m in printf. */
> - fprintf(stderr, "Failed to open %s: %m", device);
> + fprintf(stderr, "Failed to open %s: %m\n", device);
> goto out_socket;
> }
>
> diff --git a/qemu-nbd.texi b/qemu-nbd.texi
> index 0a7e013..46fd483 100644
> --- a/qemu-nbd.texi
> +++ b/qemu-nbd.texi
> @@ -15,7 +15,7 @@ Export QEMU disk image using NBD protocol.
> @item @var{filename}
> is a disk image filename
> @item -p, --port=@var{port}
> - port to listen on (default @samp{1024})
> + port to listen on (default @samp{10809})
> @item -o, --offset=@var{offset}
> offset into the image
> @item -b, --bind=@var{iface}
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2014-05-13 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 23:35 [Qemu-trivial] [PATCH 1/2] nbd: Close socket on negotiation failure Hani Benhabiles
2014-05-12 23:35 ` [Qemu-devel] " Hani Benhabiles
2014-05-12 23:35 ` [Qemu-trivial] [PATCH 2/2] nbd: Miscellaneous typo fixes Hani Benhabiles
2014-05-12 23:35 ` [Qemu-devel] " Hani Benhabiles
2014-05-13 9:08 ` Paolo Bonzini [this message]
2014-05-13 9:08 ` Paolo Bonzini
2014-05-14 12:46 ` [Qemu-trivial] " Stefan Hajnoczi
2014-05-14 12:46 ` Stefan Hajnoczi
2014-05-17 8:02 ` [Qemu-trivial] " Michael Tokarev
2014-05-17 8:02 ` [Qemu-devel] " Michael Tokarev
2014-05-13 9:07 ` [Qemu-trivial] [PATCH 1/2] nbd: Close socket on negotiation failure Paolo Bonzini
2014-05-13 9:07 ` [Qemu-devel] " Paolo Bonzini
2014-05-17 8:02 ` [Qemu-trivial] " Michael Tokarev
2014-05-17 8:02 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5371E0F9.3030105@redhat.com \
--to=pbonzini@redhat.com \
--cc=kroosec@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.