From: Christopher Covington <cov@codeaurora.org>
To: Steve Capper <steve.capper@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
linux@arm.linux.org.uk, linux-arch@vger.kernel.org,
linux-mm@kvack.org, anders.roxell@linaro.org,
peterz@infradead.org, gary.robertson@linaro.org,
will.deacon@arm.com, akpm@linux-foundation.org,
christoffer.dall@linaro.org
Subject: Re: [RFC PATCH V5 4/6] arm: mm: Enable RCU fast_gup
Date: Tue, 13 May 2014 11:31:24 -0400 [thread overview]
Message-ID: <53723ACC.7020500@codeaurora.org> (raw)
In-Reply-To: <1399390209-1756-5-git-send-email-steve.capper@linaro.org>
Hi Steve,
On 05/06/2014 11:30 AM, Steve Capper wrote:
> Activate the RCU fast_gup for ARM. We also need to force THP splits to
> broadcast an IPI s.t. we block in the fast_gup page walker. As THP
> splits are comparatively rare, this should not lead to a noticeable
> performance degradation.
> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c
> index 3387e60..91a2b59 100644
> --- a/arch/arm/mm/flush.c
> +++ b/arch/arm/mm/flush.c
> @@ -377,3 +377,22 @@ void __flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned l
> */
> __cpuc_flush_dcache_area(page_address(page), PAGE_SIZE);
> }
> +
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#ifdef CONFIG_HAVE_RCU_TABLE_FREE
This is trivia, but I for one find the form #if defined(a) && defined(b)
easier to read. (Applies to the A64 version as well).
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christopher Covington <cov@codeaurora.org>
To: Steve Capper <steve.capper@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
linux@arm.linux.org.uk, linux-arch@vger.kernel.org,
linux-mm@kvack.org, anders.roxell@linaro.org,
peterz@infradead.org, gary.robertson@linaro.org,
will.deacon@arm.com, akpm@linux-foundation.org,
christoffer.dall@linaro.org
Subject: Re: [RFC PATCH V5 4/6] arm: mm: Enable RCU fast_gup
Date: Tue, 13 May 2014 11:31:24 -0400 [thread overview]
Message-ID: <53723ACC.7020500@codeaurora.org> (raw)
Message-ID: <20140513153124.mL3GQ_cTAWHc2_X88OHtv3cXNOqw7pqa4Eq3d0vTo8g@z> (raw)
In-Reply-To: <1399390209-1756-5-git-send-email-steve.capper@linaro.org>
Hi Steve,
On 05/06/2014 11:30 AM, Steve Capper wrote:
> Activate the RCU fast_gup for ARM. We also need to force THP splits to
> broadcast an IPI s.t. we block in the fast_gup page walker. As THP
> splits are comparatively rare, this should not lead to a noticeable
> performance degradation.
> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c
> index 3387e60..91a2b59 100644
> --- a/arch/arm/mm/flush.c
> +++ b/arch/arm/mm/flush.c
> @@ -377,3 +377,22 @@ void __flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned l
> */
> __cpuc_flush_dcache_area(page_address(page), PAGE_SIZE);
> }
> +
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#ifdef CONFIG_HAVE_RCU_TABLE_FREE
This is trivia, but I for one find the form #if defined(a) && defined(b)
easier to read. (Applies to the A64 version as well).
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
WARNING: multiple messages have this Message-ID (diff)
From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH V5 4/6] arm: mm: Enable RCU fast_gup
Date: Tue, 13 May 2014 11:31:24 -0400 [thread overview]
Message-ID: <53723ACC.7020500@codeaurora.org> (raw)
In-Reply-To: <1399390209-1756-5-git-send-email-steve.capper@linaro.org>
Hi Steve,
On 05/06/2014 11:30 AM, Steve Capper wrote:
> Activate the RCU fast_gup for ARM. We also need to force THP splits to
> broadcast an IPI s.t. we block in the fast_gup page walker. As THP
> splits are comparatively rare, this should not lead to a noticeable
> performance degradation.
> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c
> index 3387e60..91a2b59 100644
> --- a/arch/arm/mm/flush.c
> +++ b/arch/arm/mm/flush.c
> @@ -377,3 +377,22 @@ void __flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned l
> */
> __cpuc_flush_dcache_area(page_address(page), PAGE_SIZE);
> }
> +
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +#ifdef CONFIG_HAVE_RCU_TABLE_FREE
This is trivia, but I for one find the form #if defined(a) && defined(b)
easier to read. (Applies to the A64 version as well).
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2014-05-13 15:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 15:30 [RFC PATCH V5 0/6] get_user_pages_fast for ARM and ARM64 Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 1/6] mm: Introduce a general RCU get_user_pages_fast Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 2/6] arm: mm: Introduce special ptes for LPAE Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 3/6] arm: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 4/6] arm: mm: Enable RCU fast_gup Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-13 15:31 ` Christopher Covington [this message]
2014-05-13 15:31 ` Christopher Covington
2014-05-13 15:31 ` Christopher Covington
2014-05-14 8:34 ` Steve Capper
2014-05-14 8:34 ` Steve Capper
2014-05-14 8:34 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 5/6] arm64: mm: Enable HAVE_RCU_TABLE_FREE logic Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` [RFC PATCH V5 6/6] arm64: mm: Enable RCU fast_gup Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
2014-05-06 15:30 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53723ACC.7020500@codeaurora.org \
--to=cov@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=gary.robertson@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=peterz@infradead.org \
--cc=steve.capper@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.