Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings

[Tushar Behera <tushar.behera@linaro.org>]

On 05/13/2014 03:37 PM, Paul Bolle wrote:
> Kukjin,
> 
> On Tue, 2014-05-13 at 12:12 +0900, Kukjin Kim wrote:
>> Tomasz Figa wrote:
>>> You mean s/sram/sysram/ in compatible strings of Exynos-specific
>>> reserved areas? If yes, I'm fine, it might be even better. Just remember
>>> to update documentation in patch 2/2 as well.
>>>
>> Done. If any problems in my tree, please let me know.
> 
> It seems this one just hit linux-next (in next-20140513) as "ARM:
> EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains
> this hunk:
>     --- a/arch/arm/Kconfig
>     +++ b/arch/arm/Kconfig
>     @@ -843,6 +843,7 @@ config ARCH_EXYNOS
>             select HAVE_S3C_RTC if RTC_CLASS
>             select NEED_MACH_MEMORY_H
>             select SPARSE_IRQ
>     +       select SYSRAM
>             select USE_OF
>             help
>               Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)
> 
> But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol
> SRAM. Did you perhaps do one s/sram/sysram/ too many on the original
> patch?
> 

Also the compatible string name should be 'mmio-sram' on the DTS files.

> 
> Paul Bolle
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Tushar Behera