From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Lukasz Majewski <l.majewski@samsung.com>
Cc: Thomas Abraham <ta.omasab@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <rob.herring@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Tomasz Figa <t.figa@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Thomas P Abraham <thomas.ab@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
Date: Wed, 14 May 2014 09:31:49 -0500 [thread overview]
Message-ID: <53737E55.9070704@ti.com> (raw)
In-Reply-To: <CAKohponG9PNse4cHkvfLfaRouW-jxjToBXUCHyOCgx8-Pc=2Xw@mail.gmail.com>
On 05/14/2014 01:24 AM, Viresh Kumar wrote:
> On 14 May 2014 11:39, Lukasz Majewski <l.majewski@samsung.com> wrote:
>> I agree with Nishanth here, that point 1 (as described by Viresh at
>> [*]) is a more scalable approach.
>
> The only reason why I wanted all that to be done at OPP level was to
> ensure if somebody else also needs it apart from cpufreq, they don't have
> to duplicate code and find it.. As it is present at a central place..
>
> But if no other code is going to look for that, it may just be fine as is..
>
If we eventually have a need beyond cpufreq (say devfreq) with similar
instances, then it makes sense to move it out to a generic place.
Either way, code implementation/duplication is a OS problem - and
should be looked at independent of the description in dts. If we feel
the description is valid hardware description (which, personally, I
do), then lets go to the next discussion point of where to put it -
generic or cpufreq specific (here, I have no preference), and finally
decide the implementation as necessary as a result of the description.
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree
Date: Wed, 14 May 2014 09:31:49 -0500 [thread overview]
Message-ID: <53737E55.9070704@ti.com> (raw)
In-Reply-To: <CAKohponG9PNse4cHkvfLfaRouW-jxjToBXUCHyOCgx8-Pc=2Xw@mail.gmail.com>
On 05/14/2014 01:24 AM, Viresh Kumar wrote:
> On 14 May 2014 11:39, Lukasz Majewski <l.majewski@samsung.com> wrote:
>> I agree with Nishanth here, that point 1 (as described by Viresh at
>> [*]) is a more scalable approach.
>
> The only reason why I wanted all that to be done at OPP level was to
> ensure if somebody else also needs it apart from cpufreq, they don't have
> to duplicate code and find it.. As it is present at a central place..
>
> But if no other code is going to look for that, it may just be fine as is..
>
If we eventually have a need beyond cpufreq (say devfreq) with similar
instances, then it makes sense to move it out to a generic place.
Either way, code implementation/duplication is a OS problem - and
should be looked at independent of the description in dts. If we feel
the description is valid hardware description (which, personally, I
do), then lets go to the next discussion point of where to put it -
generic or cpufreq specific (here, I have no preference), and finally
decide the implementation as necessary as a result of the description.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-05-14 14:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 1:02 [PATCH v3 0/2] cpufreq: opp: Add device tree based lookup of boost mode frequency Thomas Abraham
2014-05-14 1:02 ` Thomas Abraham
2014-05-14 1:02 ` [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree Thomas Abraham
2014-05-14 1:02 ` Thomas Abraham
2014-05-14 3:40 ` Viresh Kumar
2014-05-14 3:40 ` Viresh Kumar
2014-05-14 4:05 ` Nishanth Menon
2014-05-14 4:05 ` Nishanth Menon
2014-05-14 6:09 ` Lukasz Majewski
2014-05-14 6:09 ` Lukasz Majewski
2014-05-14 6:24 ` Viresh Kumar
2014-05-14 6:24 ` Viresh Kumar
2014-05-14 13:49 ` Thomas Abraham
2014-05-14 13:49 ` Thomas Abraham
2014-05-14 14:31 ` Nishanth Menon [this message]
2014-05-14 14:31 ` Nishanth Menon
2014-05-14 13:46 ` Thomas Abraham
2014-05-14 13:46 ` Thomas Abraham
2014-05-14 13:54 ` Viresh Kumar
2014-05-14 13:54 ` Viresh Kumar
2014-05-14 1:03 ` [PATCH v3 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency Thomas Abraham
2014-05-14 1:03 ` Thomas Abraham
2014-05-14 2:02 ` Nishanth Menon
2014-05-14 2:02 ` Nishanth Menon
2014-05-14 13:17 ` Thomas Abraham
2014-05-14 13:17 ` Thomas Abraham
2014-05-14 15:06 ` Sudeep Holla
2014-05-14 15:06 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53737E55.9070704@ti.com \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rob.herring@linaro.org \
--cc=t.figa@samsung.com \
--cc=ta.omasab@gmail.com \
--cc=thomas.ab@samsung.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.