All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: libxl: default behavior when libxl fail to map an IRQ
Date: Wed, 14 May 2014 17:48:05 +0100	[thread overview]
Message-ID: <53739E45.9090903@linaro.org> (raw)
In-Reply-To: <1400085827.26934.18.camel@kazak.uk.xensource.com>

On 05/14/2014 05:43 PM, Ian Campbell wrote:
> On Wed, 2014-05-14 at 17:34 +0100, Julien Grall wrote:
>> Hello all,
>>
>> It seems that libxl continue to create the domain even when the function
>> domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
>> domain.
>>
>> I looked at the code and libxl only prints an error message when an
>> error occurred. It's the same thing for MMIO and ioport.
>>
>> Shouldn't we stop to create the domain when something is failing?
> 
> yeah, it seems like all three of those loops are missing a goto
> error_out.

Thanks for you answer. I will write a patch to add a goto in theses loop.

Regards,

-- 
Julien Grall

      reply	other threads:[~2014-05-14 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 16:34 libxl: default behavior when libxl fail to map an IRQ Julien Grall
2014-05-14 16:43 ` Ian Campbell
2014-05-14 16:48   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53739E45.9090903@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.