All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Zhang <hzhang@ti.com>
To: Denys Dmytriyenko <denys@ti.com>
Cc: meta-ti@yoctoproject.org
Subject: Re: [PATCH] boot-monitor: add K2L and K2E boot monitor build support
Date: Wed, 14 May 2014 14:58:51 -0400	[thread overview]
Message-ID: <5373BCEB.9020808@ti.com> (raw)
In-Reply-To: <20140514184018.GO18053@edge>

On 5/14/2014 2:40 PM, Denys Dmytriyenko wrote:
> On Wed, May 14, 2014 at 02:29:49PM -0400, hzhang@ti.com wrote:
>> From: Hao Zhang <hzhang@ti.com>
>>
>> ---
>>  recipes-bsp/boot-monitor/boot-monitor_git.bb |   18 +++++++++++++-----
>>  1 file changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/recipes-bsp/boot-monitor/boot-monitor_git.bb b/recipes-bsp/boot-monitor/boot-monitor_git.bb
>> index 7c5e9cf..2c3aa43 100644
>> --- a/recipes-bsp/boot-monitor/boot-monitor_git.bb
>> +++ b/recipes-bsp/boot-monitor/boot-monitor_git.bb
>> @@ -3,8 +3,12 @@ EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX}"
>>  
>>  LICENSE = "BSD"
>>  
>> -BOOT_MONITOR_BINARY ?= "skern.bin"
>> -BOOT_MONITOR_IMAGE  ?= "skern-${MACHINE}.bin"
>> +BOOT_MONITOR_BINARY_K2HK ?= "skern-k2hk.bin"
>> +BOOT_MONITOR_IMAGE_k2HK  ?= "skern-k2hk-${MACHINE}.bin"
>> +BOOT_MONITOR_BINARY_K2L ?= "skern-k2l.bin"
>> +BOOT_MONITOR_IMAGE_k2L  ?= "skern-k2l-${MACHINE}.bin"
>> +BOOT_MONITOR_BINARY_K2E ?= "skern-k2e.bin"
>> +BOOT_MONITOR_IMAGE_k2E  ?= "skern-k2e-${MACHINE}.bin"
> 
> Have you tested it? You mix case in the above variables - one has K2HK 
> uppercase, another has k2HK lowercase. Same for k2l...
> 
> 

Yes, I tested it. I will correct the lowercase error and re-submit the
patch.

>>  BOOT_MONITOR_MAKE_TARGET  ?= "all"
>>  
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=25fe219a6febf6e5bb45beda1b2eb315"
>> @@ -14,7 +18,7 @@ COMPATIBLE_MACHINE = "keystone-evm"
>>  SRC_URI = "git://git.ti.com/keystone-linux/boot-monitor.git;protocol=git;branch=${BRANCH}"
>>  
>>  PV = "2.0"
>> -PR = "r0+gitr${SRCPV}"
>> +PR = "r1+gitr${SRCPV}"
>>  
>>  BRANCH = "master"
>>  
>> @@ -27,7 +31,9 @@ do_compile () {
>>  	unset LDFLAGS
>>  	unset CFLAGS
>>  	unset CPPFLAGS
>> -	oe_runmake ${BOOT_MONITOR_MAKE_TARGET}
>> +	oe_runmake k2hk
>> +	oe_runmake k2l
>> +	oe_runmake k2e
>>  }
>>  
>>  inherit deploy
>> @@ -36,5 +42,7 @@ addtask deploy before do_build after do_compile
>>  
>>  do_deploy () {
>>  	install -d ${DEPLOYDIR}
>> -	install ${S}/${BOOT_MONITOR_BINARY} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE}
>> +	install ${S}/${BOOT_MONITOR_BINARY_K2HK} ${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2HK}
>> +	install ${S}/${BOOT_MONITOR_BINARY_K2L}	${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2L}
>> +	install ${S}/${BOOT_MONITOR_BINARY_K2E}	${DEPLOYDIR}/${BOOT_MONITOR_IMAGE_K2E}
>>  }
>> -- 
>> 1.7.9.5
>>
>> -- 
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti



  reply	other threads:[~2014-05-14 19:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 18:29 [PATCH] boot-monitor: add K2L and K2E boot monitor build support hzhang
2014-05-14 18:40 ` Denys Dmytriyenko
2014-05-14 18:58   ` Hao Zhang [this message]
2014-05-14 19:01     ` Denys Dmytriyenko
2014-05-14 19:55       ` Maupin, Chase
2014-05-14 20:38         ` Hao Zhang
2014-05-15 14:21           ` Maupin, Chase
2014-05-15 14:41             ` Hao Zhang
2014-05-15 14:54               ` Denys Dmytriyenko
2014-05-15 15:07                 ` Hao Zhang
2014-05-15 15:38                   ` Santosh Shilimkar
2014-05-15 15:56                     ` Maupin, Chase
2014-05-15 16:06                       ` Santosh Shilimkar
2014-05-15 16:11                         ` Denys Dmytriyenko
2014-05-15 16:14                           ` Santosh Shilimkar
2014-05-15 16:22                             ` Maupin, Chase
2014-05-15 16:26                               ` Hao Zhang
2014-05-15 16:33                                 ` Denys Dmytriyenko
2014-06-04 13:48                                   ` Maupin, Chase
2014-06-04 15:04                                     ` Denys Dmytriyenko
2014-06-05 15:12                                       ` Denys Dmytriyenko
2014-05-15 15:20                 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5373BCEB.9020808@ti.com \
    --to=hzhang@ti.com \
    --cc=denys@ti.com \
    --cc=meta-ti@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.