All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
@ 2014-04-02 15:28 Ross Zwisler
  0 siblings, 0 replies; 9+ messages in thread
From: Ross Zwisler @ 2014-04-02 15:28 UTC (permalink / raw)
  To: David Airlie, dri-devel, willy; +Cc: Ross Zwisler

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush
in drm_clflush_virt_range.  There were two calls to clflush in this
function, but only one was changed to clflushopt.  This patch changes
the other clflush call to clflushopt.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
---
 drivers/gpu/drm/drm_cache.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index 534cb89..041b73b 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
 		char *end = addr + length;
 		mb();
 		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
-			clflush(addr);
+			clflushopt(addr);
 		clflushopt(end - 1);
 		mb();
 		return;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
       [not found] <CF7ADB41.27CDE%ross.zwisler@linux.intel.com>
@ 2014-04-21 20:28 ` Ross Zwisler
  2014-04-28 22:57   ` David Herrmann
  0 siblings, 1 reply; 9+ messages in thread
From: Ross Zwisler @ 2014-04-21 20:28 UTC (permalink / raw)
  To: Ross Zwisler; +Cc: willy, dri-devel

On Wed, 2 Apr 2014, Ross Zwisler wrote:
> With this commit:
> 
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> 
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range.  There were two calls to clflush in this
> function, but only one was changed to clflushopt.  This patch changes
> the other clflush call to clflushopt.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> ---
>  drivers/gpu/drm/drm_cache.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>  		char *end = addr + length;
>  		mb();
>  		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> -			clflush(addr);
> +			clflushopt(addr);
>  		clflushopt(end - 1);
>  		mb();
>  		return;
> -- 
> 1.7.10.4

Ping?  :)

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
  2014-04-21 20:28 ` Ross Zwisler
@ 2014-04-28 22:57   ` David Herrmann
  0 siblings, 0 replies; 9+ messages in thread
From: David Herrmann @ 2014-04-28 22:57 UTC (permalink / raw)
  To: Ross Zwisler, H. Peter Anvin; +Cc: willy, dri-devel@lists.freedesktop.org

Hi

On Mon, Apr 21, 2014 at 10:28 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> On Wed, 2 Apr 2014, Ross Zwisler wrote:
>> With this commit:
>>
>> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
>>
>> If clflushopt is available on the system, we use it instead of clflush
>> in drm_clflush_virt_range.  There were two calls to clflush in this
>> function, but only one was changed to clflushopt.  This patch changes
>> the other clflush call to clflushopt.
>>
>> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
>> ---
>>  drivers/gpu/drm/drm_cache.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
>> index 534cb89..041b73b 100644
>> --- a/drivers/gpu/drm/drm_cache.c
>> +++ b/drivers/gpu/drm/drm_cache.c
>> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>>               char *end = addr + length;
>>               mb();
>>               for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
>> -                     clflush(addr);
>> +                     clflushopt(addr);
>>               clflushopt(end - 1);
>>               mb();
>>               return;
>> --
>> 1.7.10.4
>
> Ping?  :)

This was merged through -tip, right? The DRM tree does not include the
initial patches, yet, so I'd recommend merging this through -tip
again. I've put hpa on CC for that. However, I cannot see where the
initial patch was sent to, so can you resent it properly to lkml,
please? And please also put the respective maintainers on CC.

Thanks
David

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
@ 2014-05-14 15:41 Ross Zwisler
  2014-05-15 12:38   ` Daniel Vetter
  0 siblings, 1 reply; 9+ messages in thread
From: Ross Zwisler @ 2014-05-14 15:41 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ross Zwisler, David Airlie, dri-devel, H Peter Anvin, Ingo Molnar,
	Thomas Gleixner

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush
in drm_clflush_virt_range.  There were two calls to clflush in this
function, but only one was changed to clflushopt.  This patch changes
the other clflush call to clflushopt.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>

Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: H Peter Anvin <h.peter.anvin@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/gpu/drm/drm_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index 534cb89..041b73b 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
 		char *end = addr + length;
 		mb();
 		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
-			clflush(addr);
+			clflushopt(addr);
 		clflushopt(end - 1);
 		mb();
 		return;
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
  2014-05-14 15:41 [PATCH] drm: Missed clflushopt in drm_clflush_virt_range Ross Zwisler
@ 2014-05-15 12:38   ` Daniel Vetter
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2014-05-15 12:38 UTC (permalink / raw)
  To: Ross Zwisler
  Cc: Thomas Gleixner, H Peter Anvin, linux-kernel, dri-devel,
	Ingo Molnar

On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> With this commit:
> 
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> 
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range.  There were two calls to clflush in this
> function, but only one was changed to clflushopt.  This patch changes
> the other clflush call to clflushopt.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: H Peter Anvin <h.peter.anvin@intel.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Picked to my topic/core-stuff drm branch so it doesn't get lost.
-Daniel

> 
> ---
>  drivers/gpu/drm/drm_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>  		char *end = addr + length;
>  		mb();
>  		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> -			clflush(addr);
> +			clflushopt(addr);
>  		clflushopt(end - 1);
>  		mb();
>  		return;
> -- 
> 1.9.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
@ 2014-05-15 12:38   ` Daniel Vetter
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2014-05-15 12:38 UTC (permalink / raw)
  To: Ross Zwisler
  Cc: linux-kernel, dri-devel, Ingo Molnar, H Peter Anvin,
	Thomas Gleixner

On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> With this commit:
> 
> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> 
> If clflushopt is available on the system, we use it instead of clflush
> in drm_clflush_virt_range.  There were two calls to clflush in this
> function, but only one was changed to clflushopt.  This patch changes
> the other clflush call to clflushopt.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: H Peter Anvin <h.peter.anvin@intel.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Picked to my topic/core-stuff drm branch so it doesn't get lost.
-Daniel

> 
> ---
>  drivers/gpu/drm/drm_cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
> index 534cb89..041b73b 100644
> --- a/drivers/gpu/drm/drm_cache.c
> +++ b/drivers/gpu/drm/drm_cache.c
> @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
>  		char *end = addr + length;
>  		mb();
>  		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
> -			clflush(addr);
> +			clflushopt(addr);
>  		clflushopt(end - 1);
>  		mb();
>  		return;
> -- 
> 1.9.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
  2014-05-15 12:38   ` Daniel Vetter
  (?)
@ 2014-05-15 14:37   ` H. Peter Anvin
  2014-05-15 20:40       ` Daniel Vetter
  -1 siblings, 1 reply; 9+ messages in thread
From: H. Peter Anvin @ 2014-05-15 14:37 UTC (permalink / raw)
  To: Ross Zwisler, linux-kernel, dri-devel, Ingo Molnar,
	Thomas Gleixner

On 05/15/2014 05:38 AM, Daniel Vetter wrote:
> On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
>> With this commit:
>>
>> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
>>
>> If clflushopt is available on the system, we use it instead of clflush
>> in drm_clflush_virt_range.  There were two calls to clflush in this
>> function, but only one was changed to clflushopt.  This patch changes
>> the other clflush call to clflushopt.
>>
>> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
>>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: H Peter Anvin <h.peter.anvin@intel.com>
>> Cc: Ingo Molnar <mingo@kernel.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
> 
> Picked to my topic/core-stuff drm branch so it doesn't get lost.
> -Daniel
> 

Does this mean you're picking this up, or do you want me to put it into
-tip?

	-hpa

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
  2014-05-15 14:37   ` H. Peter Anvin
@ 2014-05-15 20:40       ` Daniel Vetter
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2014-05-15 20:40 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Ross Zwisler, Thomas Gleixner, linux-kernel, dri-devel,
	Ingo Molnar

On Thu, May 15, 2014 at 07:37:32AM -0700, H. Peter Anvin wrote:
> On 05/15/2014 05:38 AM, Daniel Vetter wrote:
> > On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> >> With this commit:
> >>
> >> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> >>
> >> If clflushopt is available on the system, we use it instead of clflush
> >> in drm_clflush_virt_range.  There were two calls to clflush in this
> >> function, but only one was changed to clflushopt.  This patch changes
> >> the other clflush call to clflushopt.
> >>
> >> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> >> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> >>
> >> Cc: David Airlie <airlied@linux.ie>
> >> Cc: dri-devel@lists.freedesktop.org
> >> Cc: H Peter Anvin <h.peter.anvin@intel.com>
> >> Cc: Ingo Molnar <mingo@kernel.org>
> >> Cc: Thomas Gleixner <tglx@linutronix.de>
> > 
> > Picked to my topic/core-stuff drm branch so it doesn't get lost.
> > -Daniel
> > 
> 
> Does this mean you're picking this up, or do you want me to put it into

I'll forward it eventually to Dave for 3.16. But if someone else steals it
beforehand I don't mind ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range
@ 2014-05-15 20:40       ` Daniel Vetter
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2014-05-15 20:40 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Ross Zwisler, linux-kernel, dri-devel, Ingo Molnar,
	Thomas Gleixner

On Thu, May 15, 2014 at 07:37:32AM -0700, H. Peter Anvin wrote:
> On 05/15/2014 05:38 AM, Daniel Vetter wrote:
> > On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote:
> >> With this commit:
> >>
> >> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range
> >>
> >> If clflushopt is available on the system, we use it instead of clflush
> >> in drm_clflush_virt_range.  There were two calls to clflush in this
> >> function, but only one was changed to clflushopt.  This patch changes
> >> the other clflush call to clflushopt.
> >>
> >> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> >> Reported-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
> >>
> >> Cc: David Airlie <airlied@linux.ie>
> >> Cc: dri-devel@lists.freedesktop.org
> >> Cc: H Peter Anvin <h.peter.anvin@intel.com>
> >> Cc: Ingo Molnar <mingo@kernel.org>
> >> Cc: Thomas Gleixner <tglx@linutronix.de>
> > 
> > Picked to my topic/core-stuff drm branch so it doesn't get lost.
> > -Daniel
> > 
> 
> Does this mean you're picking this up, or do you want me to put it into

I'll forward it eventually to Dave for 3.16. But if someone else steals it
beforehand I don't mind ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-15 20:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 15:41 [PATCH] drm: Missed clflushopt in drm_clflush_virt_range Ross Zwisler
2014-05-15 12:38 ` Daniel Vetter
2014-05-15 12:38   ` Daniel Vetter
2014-05-15 14:37   ` H. Peter Anvin
2014-05-15 20:40     ` Daniel Vetter
2014-05-15 20:40       ` Daniel Vetter
     [not found] <CF7ADB41.27CDE%ross.zwisler@linux.intel.com>
2014-04-21 20:28 ` Ross Zwisler
2014-04-28 22:57   ` David Herrmann
  -- strict thread matches above, loose matches on Subject: below --
2014-04-02 15:28 Ross Zwisler

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.