* [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
@ 2014-05-15 10:08 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2014-05-15 10:08 UTC (permalink / raw)
To: Kumar Gala
Cc: David Brown, Russell King, linux-arm-msm, linux-arm-kernel,
linux-kernel, Srinivas Kandagatla
As some of the IPs on Qualcomm SOCs are based on ARM PrimeCell IPs.
For example SDCC controller is PrimeCell MCI pl180. Adding this option will
give flexibility to reuse the existing drivers as it is without major
modifications.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm/mach-qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
index a028be2..5bac591 100644
--- a/arch/arm/mach-qcom/Kconfig
+++ b/arch/arm/mach-qcom/Kconfig
@@ -2,6 +2,7 @@ config ARCH_QCOM
bool "Qualcomm Support" if ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select ARM_GIC
+ select ARM_AMBA
select CLKSRC_OF
select GENERIC_CLOCKEVENTS
select HAVE_SMP
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
@ 2014-05-15 10:08 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2014-05-15 10:08 UTC (permalink / raw)
To: linux-arm-kernel
As some of the IPs on Qualcomm SOCs are based on ARM PrimeCell IPs.
For example SDCC controller is PrimeCell MCI pl180. Adding this option will
give flexibility to reuse the existing drivers as it is without major
modifications.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm/mach-qcom/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
index a028be2..5bac591 100644
--- a/arch/arm/mach-qcom/Kconfig
+++ b/arch/arm/mach-qcom/Kconfig
@@ -2,6 +2,7 @@ config ARCH_QCOM
bool "Qualcomm Support" if ARCH_MULTI_V7
select ARCH_REQUIRE_GPIOLIB
select ARM_GIC
+ select ARM_AMBA
select CLKSRC_OF
select GENERIC_CLOCKEVENTS
select HAVE_SMP
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
2014-05-15 10:08 ` Srinivas Kandagatla
@ 2014-05-15 14:31 ` Kumar Gala
-1 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2014-05-15 14:31 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: David Brown, Russell King, linux-arm-msm, linux-arm-kernel,
linux-kernel
On May 15, 2014, at 5:08 AM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
> As some of the IPs on Qualcomm SOCs are based on ARM PrimeCell IPs.
> For example SDCC controller is PrimeCell MCI pl180. Adding this option will
> give flexibility to reuse the existing drivers as it is without major
> modifications.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/mach-qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index a028be2..5bac591 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -2,6 +2,7 @@ config ARCH_QCOM
> bool "Qualcomm Support" if ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARM_GIC
> + select ARM_AMBA
> select CLKSRC_OF
> select GENERIC_CLOCKEVENTS
> select HAVE_SMP
> --
> 1.9.1
I’d rather have the driver have the select of ARM_AMBA and not the core support. We clearly don’t need to build ARM_AMBA in to function.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
@ 2014-05-15 14:31 ` Kumar Gala
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2014-05-15 14:31 UTC (permalink / raw)
To: linux-arm-kernel
On May 15, 2014, at 5:08 AM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote:
> As some of the IPs on Qualcomm SOCs are based on ARM PrimeCell IPs.
> For example SDCC controller is PrimeCell MCI pl180. Adding this option will
> give flexibility to reuse the existing drivers as it is without major
> modifications.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/mach-qcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index a028be2..5bac591 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -2,6 +2,7 @@ config ARCH_QCOM
> bool "Qualcomm Support" if ARCH_MULTI_V7
> select ARCH_REQUIRE_GPIOLIB
> select ARM_GIC
> + select ARM_AMBA
> select CLKSRC_OF
> select GENERIC_CLOCKEVENTS
> select HAVE_SMP
> --
> 1.9.1
I?d rather have the driver have the select of ARM_AMBA and not the core support. We clearly don?t need to build ARM_AMBA in to function.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
2014-05-15 14:31 ` Kumar Gala
@ 2014-05-15 14:56 ` Srinivas Kandagatla
-1 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2014-05-15 14:56 UTC (permalink / raw)
To: Kumar Gala
Cc: David Brown, Russell King, linux-arm-msm, linux-arm-kernel,
linux-kernel
Hi Kumar,
On 15/05/14 15:31, Kumar Gala wrote:
> I’d rather have the driver have the select of ARM_AMBA and not the core support. We clearly don’t need to build ARM_AMBA in to function.
Shouldn’t driver depend on it rather than selecting it?
Suggested approach will end up changing the way its done on other SOCs,
Currently all the SOCs select ARM_AMBA at there machine level Kconfig
rather than each individual driver selecting it.
Am open to do it either way but doing it the way it exists is the
something more acceptable I thought.
thanks,
srini
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS.
@ 2014-05-15 14:56 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2014-05-15 14:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kumar,
On 15/05/14 15:31, Kumar Gala wrote:
> I?d rather have the driver have the select of ARM_AMBA and not the core support. We clearly don?t need to build ARM_AMBA in to function.
Shouldn?t driver depend on it rather than selecting it?
Suggested approach will end up changing the way its done on other SOCs,
Currently all the SOCs select ARM_AMBA at there machine level Kconfig
rather than each individual driver selecting it.
Am open to do it either way but doing it the way it exists is the
something more acceptable I thought.
thanks,
srini
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-15 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 10:08 [PATCH] ARM: QCOM: Enable ARM_AMBA option for Qcom SOCS Srinivas Kandagatla
2014-05-15 10:08 ` Srinivas Kandagatla
2014-05-15 14:31 ` Kumar Gala
2014-05-15 14:31 ` Kumar Gala
2014-05-15 14:56 ` Srinivas Kandagatla
2014-05-15 14:56 ` Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.