* [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes
@ 2014-05-15 16:57 Fabian Frederick
2014-05-16 8:39 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-05-15 16:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Steven Whitehouse, akpm
Related function is not gfs2_set_flags but do_gfs2_set_flags
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/gfs2/file.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 80d6725..768cbd4 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -203,9 +203,9 @@ void gfs2_set_inode_flags(struct inode *inode)
GFS2_DIF_INHERIT_JDATA)
/**
- * gfs2_set_flags - set flags on an inode
- * @inode: The inode
- * @flags: The flags to set
+ * do_gfs2_set_flags - set flags on an inode
+ * @filp: file pointer
+ * @reqflags: The flags to set
* @mask: Indicates which flags are valid
*
*/
@@ -318,7 +318,7 @@ static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
/**
* gfs2_size_hint - Give a hint to the size of a write request
- * @file: The struct file
+ * @filep: The struct file
* @offset: The file offset of the write
* @size: The length of the write
*
@@ -371,7 +371,7 @@ static int gfs2_allocate_page_backing(struct page *page)
/**
* gfs2_page_mkwrite - Make a shared, mmap()ed, page writable
* @vma: The virtual memory area
- * @page: The page which is about to become writable
+ * @vmf: The virtual memory fault containing the page to become writable
*
* When the page becomes writable, we need to ensure that we have
* blocks allocated on disk to back that page.
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes
2014-05-15 16:57 [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes Fabian Frederick
@ 2014-05-16 8:39 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-05-16 8:39 UTC (permalink / raw)
To: Fabian Frederick, linux-kernel; +Cc: akpm
Hi,
I've added this patch, plus the one you sent yesterday to the GFS2 -nmw
tree. Thanks,
Steve.
On 15/05/14 17:57, Fabian Frederick wrote:
> Related function is not gfs2_set_flags but do_gfs2_set_flags
>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/gfs2/file.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> index 80d6725..768cbd4 100644
> --- a/fs/gfs2/file.c
> +++ b/fs/gfs2/file.c
> @@ -203,9 +203,9 @@ void gfs2_set_inode_flags(struct inode *inode)
> GFS2_DIF_INHERIT_JDATA)
>
> /**
> - * gfs2_set_flags - set flags on an inode
> - * @inode: The inode
> - * @flags: The flags to set
> + * do_gfs2_set_flags - set flags on an inode
> + * @filp: file pointer
> + * @reqflags: The flags to set
> * @mask: Indicates which flags are valid
> *
> */
> @@ -318,7 +318,7 @@ static long gfs2_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>
> /**
> * gfs2_size_hint - Give a hint to the size of a write request
> - * @file: The struct file
> + * @filep: The struct file
> * @offset: The file offset of the write
> * @size: The length of the write
> *
> @@ -371,7 +371,7 @@ static int gfs2_allocate_page_backing(struct page *page)
> /**
> * gfs2_page_mkwrite - Make a shared, mmap()ed, page writable
> * @vma: The virtual memory area
> - * @page: The page which is about to become writable
> + * @vmf: The virtual memory fault containing the page to become writable
> *
> * When the page becomes writable, we need to ensure that we have
> * blocks allocated on disk to back that page.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-16 8:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 16:57 [PATCH 1/1] fs/gfs2/file.c: kernel-doc warning fixes Fabian Frederick
2014-05-16 8:39 ` Steven Whitehouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.