[U-Boot] [AVR32] CONFIG_SYS_TEXT_BASE is missing from atngw100mkii board

[U-Boot] [AVR32] CONFIG_SYS_TEXT_BASE is missing from atngw100mkii board

[Masahiro Yamada]

Hi Andreass,


I noticed by chance  atngw100mkii board does not define
CONFIG_SYS_TEXT_BASE, although the other AVR32 boards define it.

Is this your intention, or mistake?


This is what I did:

$ git branch 
* master
$ git describe 
v2014.07-rc1-79-g2072e72
$ make mrproper 
$ make  atngw100mkii_config
Configuring for atngw100mkii board...
$ make -s -j8 CROSS_COMPILE=avr32-linux-
$ grep CONFIG_SYS_TEXT_BASE include/autoconf.mk
$

I can't find CONFIG_SYS_TEXT_BASE in include/autoconf.mk


Best Regards
Masahiro Yamada

[U-Boot] [AVR32] CONFIG_SYS_TEXT_BASE is missing from atngw100mkii board

[Andreas Bießmann]

Hi Masahiro,

On 05/16/2014 07:48 AM, Masahiro Yamada wrote:
> Hi Andreass,
> 
> 
> I noticed by chance  atngw100mkii board does not define
> CONFIG_SYS_TEXT_BASE, although the other AVR32 boards define it.
> 
> Is this your intention, or mistake?

oups. I can't remember why this is missing. Maybe cause the
CONFIG_SYS_TEXT_BASE is set to 0x0 implicitly?

abiessmann at punisher % PATH=$AVR32_PATH:$PATH make atngw100mkii_config
Configuring for atngw100mkii board...
abiessmann at punisher % PATH=$AVR32_PATH:$PATH make V=1 -j16
CROSS_COMPILE=avr32-linux- | grep CONFIG_SYS_TEXT_BASE
  avr32-linux-gcc -x c -DDO_DEPS_ONLY -M -Wall -Wstrict-prototypes
-Wno-format-security -fno-builtin -ffreestanding -Os
-fno-stack-protector -g -Wno-format-nonliteral   -D__KERNEL__
-DCONFIG_SYS_TEXT_BASE=0x00000000   -DCONFIG_AVR32  -ffixed-r5 -fPIC
-mno-init-got -mrelax -ffunction-sections -fdata-sections -mcpu=ap7000
-pipe -Iinclude  -I/home/abiessmann/src/u-boot/arch/avr32/include
-nostdinc -isystem
/opt/OSELAS.Toolchain-2011.11.0/avr32-linux/gcc-4.4.7-uclibc-0.9.33.2-binutils-2.20.1a-kernel-2.6.39-sanitized/lib/gcc/avr32-linux/4.4.7/include
-MQ include/autoconf.mk /home/abiessmann/src/u-boot/include/common.h >
include/autoconf.mk.dep || rm include/autoconf.mk.dep
...

0x0 is the correct address for avr32 devices, so presumably the
CONFIG_SYS_TEXT_BASE parameter was forgotten when writing the
atngw100mkii header file.
I'll prepare a patch to add it.

Best regards

Andreas

[U-Boot] [AVR32] CONFIG_SYS_TEXT_BASE is missing from atngw100mkii board

[Masahiro Yamada]

Hi Andreas,

> 
> 0x0 is the correct address for avr32 devices, so presumably the
> CONFIG_SYS_TEXT_BASE parameter was forgotten when writing the
> atngw100mkii header file.
> I'll prepare a patch to add it.

If CONFIG_SYS_TEXT_BASE is missing,
.text section will start at 0x00000000 and
it works in this case.

But it would be better to fix it just in case.

Thank you for posting the patch.


Best Regards
Masahiro Yamada