From: Richard Henderson <rth@twiddle.net>
To: Petar Jovanovic <petar.jovanovic@rt-rk.com>, qemu-devel@nongnu.org
Cc: petar.jovanovic@imgtec.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 1/2] target-mips: pass CPUMIPSState to gen_mfc0/mtc0/dmfc0/dmtc0
Date: Sat, 17 May 2014 11:03:16 -0700 [thread overview]
Message-ID: <5377A464.5090300@twiddle.net> (raw)
In-Reply-To: <1400264014-78911-2-git-send-email-petar.jovanovic@rt-rk.com>
On 05/16/2014 11:13 AM, Petar Jovanovic wrote:
>
> -static void gen_mfc0(DisasContext *ctx, TCGv arg, int reg, int sel)
> +static void gen_mfc0(CPUMIPSState *env, DisasContext *ctx,
> +
You should not be passing around env within the translator, at all.
You should be able to get everything you need from ctx->hflags
or ctx->insn_flags. If there's something missing from ctx, then
we'll talk about additional changes.
r~
next prev parent reply other threads:[~2014-05-17 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 18:13 [Qemu-devel] [PATCH 0/2] implementation of UserLocal register for MIPS Petar Jovanovic
2014-05-16 18:13 ` [Qemu-devel] [PATCH 1/2] target-mips: pass CPUMIPSState to gen_mfc0/mtc0/dmfc0/dmtc0 Petar Jovanovic
2014-05-17 18:03 ` Richard Henderson [this message]
2014-05-16 18:13 ` [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register Petar Jovanovic
2014-05-17 18:11 ` Richard Henderson
2014-05-22 0:03 ` James Hogan
2014-05-22 0:19 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5377A464.5090300@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=petar.jovanovic@imgtec.com \
--cc=petar.jovanovic@rt-rk.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.