From: Guenter Roeck <linux@roeck-us.net>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [hwmon:watchdog-next 18/34] arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic'
Date: Sat, 17 May 2014 21:58:00 -0700 [thread overview]
Message-ID: <53783DD8.6070908@roeck-us.net> (raw)
In-Reply-To: <20140518032052.GA545@psi-dev26.jf.intel.com>
On 05/17/2014 08:20 PM, David Cohen wrote:
> On Thu, May 15, 2014 at 10:42:21AM -0700, David Cohen wrote:
>> On Thu, May 15, 2014 at 10:19:47AM -0700, Guenter Roeck wrote:
>>> Hi David,
>>
>> Hi Guenter,
>>
>>>
>>> can you look into this ? This is from your patch 'x86: intel-mid: add watchdog
>>> platform code for Merrifield'.
>>
>> Thanks for the info.
>>
>>>
>>> Maybe the code should depend on X86_IO_APIC,
>>> or include asm/io_apic.h explicitly (which might be appropriate anyway).
>>
>> I'll send a fix.
>
> Do you prefer an incremental patch fixing this issue or a replacement
> for the first one?
>
I would suggest incremental; Wim can then decide if he wants to merge the two patches
into one or keep them separate.
Guenter
next prev parent reply other threads:[~2014-05-18 4:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5374a77f.J4+vnB3mNfBZ172K%fengguang.wu@intel.com>
[not found] ` <20140515171947.GA18562@roeck-us.net>
2014-05-15 17:42 ` [hwmon:watchdog-next 18/34] arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' David Cohen
2014-05-18 3:20 ` David Cohen
2014-05-18 4:58 ` Guenter Roeck [this message]
2014-05-26 21:18 ` Wim Van Sebroeck
2014-05-27 21:11 ` [PATCH] x86: intel-mid: fix watchdog platform code David Cohen
2014-05-27 21:21 ` David Cohen
2014-05-27 23:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53783DD8.6070908@roeck-us.net \
--to=linux@roeck-us.net \
--cc=david.a.cohen@linux.intel.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.