All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: David Cohen <david.a.cohen@linux.intel.com>,
	wim@iguana.be, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnomes@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] x86: intel-mid: fix watchdog platform code
Date: Tue, 27 May 2014 16:34:39 -0700	[thread overview]
Message-ID: <5385210F.4030205@roeck-us.net> (raw)
In-Reply-To: <1401225670-28959-1-git-send-email-david.a.cohen@linux.intel.com>

On 05/27/2014 02:21 PM, David Cohen wrote:
> This patch fixes missing include asm/io_apic.h which may lead to
> following error:
>
>     arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
>       ioapic = mp_find_ioapic(irq);
>       ^
>>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
>        ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
>        ^
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>


      reply	other threads:[~2014-05-27 23:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5374a77f.J4+vnB3mNfBZ172K%fengguang.wu@intel.com>
     [not found] ` <20140515171947.GA18562@roeck-us.net>
2014-05-15 17:42   ` [hwmon:watchdog-next 18/34] arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' David Cohen
2014-05-18  3:20     ` David Cohen
2014-05-18  4:58       ` Guenter Roeck
2014-05-26 21:18       ` Wim Van Sebroeck
2014-05-27 21:11         ` [PATCH] x86: intel-mid: fix watchdog platform code David Cohen
2014-05-27 21:21           ` David Cohen
2014-05-27 23:34             ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5385210F.4030205@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=david.a.cohen@linux.intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wim@iguana.be \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.