From: Stefan Weil <sw@weilnetz.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable
Date: Mon, 19 May 2014 09:38:56 +0200 [thread overview]
Message-ID: <5379B510.6000907@weilnetz.de> (raw)
In-Reply-To: <1400480365.32155.21.camel@nilsson.home.kraxel.org>
Am 19.05.2014 08:19, schrieb Gerd Hoffmann:
> Hi,
>
>> +if test "$gtkabi" = ""; then
>> + # The GTK ABI was not specified explicitly, so try whether 2.0 is available.
>> + # Use 3.0 as a fallback if that is available.
>> + if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then
>> + gtkabi=2.0
>> + elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
>> + gtkabi=3.0
>> + else
>> + gtkabi=2.0
>> + fi
>> +fi
> Shouldn't we probe for gtk3 first?
>
> cheers,
> Gerd
That sounds reasonable, but would result in a non trivial change for all
developers who build on a system with both GTK versions. I tried to
preserve the current default (2.0) as far as possible.
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable
Date: Mon, 19 May 2014 09:38:56 +0200 [thread overview]
Message-ID: <5379B510.6000907@weilnetz.de> (raw)
In-Reply-To: <1400480365.32155.21.camel@nilsson.home.kraxel.org>
Am 19.05.2014 08:19, schrieb Gerd Hoffmann:
> Hi,
>
>> +if test "$gtkabi" = ""; then
>> + # The GTK ABI was not specified explicitly, so try whether 2.0 is available.
>> + # Use 3.0 as a fallback if that is available.
>> + if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then
>> + gtkabi=2.0
>> + elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then
>> + gtkabi=3.0
>> + else
>> + gtkabi=2.0
>> + fi
>> +fi
> Shouldn't we probe for gtk3 first?
>
> cheers,
> Gerd
That sounds reasonable, but would result in a non trivial change for all
developers who build on a system with both GTK versions. I tried to
preserve the current default (2.0) as far as possible.
Stefan
next prev parent reply other threads:[~2014-05-19 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 14:29 [Qemu-trivial] [PATCH] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable Stefan Weil
2014-05-17 14:29 ` [Qemu-devel] " Stefan Weil
2014-05-19 6:19 ` [Qemu-trivial] " Gerd Hoffmann
2014-05-19 6:19 ` Gerd Hoffmann
2014-05-19 7:38 ` Stefan Weil [this message]
2014-05-19 7:38 ` Stefan Weil
2014-05-19 7:57 ` [Qemu-trivial] " Gerd Hoffmann
2014-05-19 7:57 ` Gerd Hoffmann
2014-05-19 7:49 ` [Qemu-trivial] " Michael Tokarev
2014-05-19 7:49 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5379B510.6000907@weilnetz.de \
--to=sw@weilnetz.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.