From: Roger Quadros <rogerq@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: rydberg@euromail.se, balbi@ti.com, dmurphy@ti.com,
mugunthanvnm@ti.com, nsekhar@ti.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 7/7] Input: pixcir_i2c_ts: Add device tree support
Date: Mon, 19 May 2014 10:50:58 +0300 [thread overview]
Message-ID: <5379B7E2.30904@ti.com> (raw)
In-Reply-To: <20140519055421.GF29386@core.coreip.homeip.net>
On 05/19/2014 08:54 AM, Dmitry Torokhov wrote:
> On Tue, May 06, 2014 at 02:06:12PM +0300, Roger Quadros wrote:
>> Provide device tree support and binding information.
>> Also provide support for a new chip "pixcir_tangoc".
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 ++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> drivers/input/touchscreen/pixcir_i2c_ts.c | 78 ++++++++++++++++++++++
>> 3 files changed, 105 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt b/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>> new file mode 100644
>> index 0000000..0ab9505
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>> @@ -0,0 +1,26 @@
>> +* Pixcir I2C touchscreen controllers
>> +
>> +Required properties:
>> +- compatible: must be "pixcir,pixcir_ts" or "pixcir,pixcir_tangoc"
>> +- reg: I2C address of the chip
>> +- interrupts: interrupt to which the chip is connected
>> +- attb-gpio: GPIO connected to the ATTB line of the chip
>> +- x-size: horizontal resolution of touchscreen
>> +- y-size: vertical resolution of touchscreen
>
> There is a patch by Sebastian Reichel trying to unify touchscreen OF
> properties, I think it would be nice if we used the same properties
> here.
OK, I'll update this patch.
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <rydberg@euromail.se>, <balbi@ti.com>, <dmurphy@ti.com>,
<mugunthanvnm@ti.com>, <nsekhar@ti.com>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 7/7] Input: pixcir_i2c_ts: Add device tree support
Date: Mon, 19 May 2014 10:50:58 +0300 [thread overview]
Message-ID: <5379B7E2.30904@ti.com> (raw)
In-Reply-To: <20140519055421.GF29386@core.coreip.homeip.net>
On 05/19/2014 08:54 AM, Dmitry Torokhov wrote:
> On Tue, May 06, 2014 at 02:06:12PM +0300, Roger Quadros wrote:
>> Provide device tree support and binding information.
>> Also provide support for a new chip "pixcir_tangoc".
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> .../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26 ++++++++
>> .../devicetree/bindings/vendor-prefixes.txt | 1 +
>> drivers/input/touchscreen/pixcir_i2c_ts.c | 78 ++++++++++++++++++++++
>> 3 files changed, 105 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt b/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>> new file mode 100644
>> index 0000000..0ab9505
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt
>> @@ -0,0 +1,26 @@
>> +* Pixcir I2C touchscreen controllers
>> +
>> +Required properties:
>> +- compatible: must be "pixcir,pixcir_ts" or "pixcir,pixcir_tangoc"
>> +- reg: I2C address of the chip
>> +- interrupts: interrupt to which the chip is connected
>> +- attb-gpio: GPIO connected to the ATTB line of the chip
>> +- x-size: horizontal resolution of touchscreen
>> +- y-size: vertical resolution of touchscreen
>
> There is a patch by Sebastian Reichel trying to unify touchscreen OF
> properties, I think it would be nice if we used the same properties
> here.
OK, I'll update this patch.
cheers,
-roger
next prev parent reply other threads:[~2014-05-19 7:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 11:06 [PATCH v5 0/7] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-06 11:06 ` [PATCH v5 1/7] Input: pixcir_i2c_ts: Use devres managed resource allocations Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:54 ` Dmitry Torokhov
2014-05-06 11:06 ` [PATCH v5 3/7] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:55 ` Dmitry Torokhov
2014-05-06 11:06 ` [PATCH v5 4/7] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:54 ` Dmitry Torokhov
2014-05-19 7:04 ` Henrik Rydberg
[not found] ` <5379ACF1.6080305-Hk7bIW8heu4wFerOooGFRg@public.gmane.org>
2014-05-19 7:42 ` Roger Quadros
2014-05-19 7:42 ` Roger Quadros
[not found] ` <1399374372-29123-5-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-19 8:24 ` [PATCH v6 " Roger Quadros
2014-05-19 8:24 ` Roger Quadros
2014-06-04 8:53 ` Roger Quadros
2014-06-04 8:53 ` Roger Quadros
[not found] ` <1399374372-29123-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-05-06 11:06 ` [PATCH v5 2/7] Input: pixcir_i2c_ts - initialize interrupt mode and power mode Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:55 ` Dmitry Torokhov
2014-05-06 11:06 ` [PATCH v5 5/7] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 8:26 ` [PATCH v6 " Roger Quadros
2014-05-19 8:26 ` Roger Quadros
2014-05-06 11:06 ` [PATCH v5 6/7] Input: pixcir_i2c_ts: Implement wakeup from suspend Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:55 ` Dmitry Torokhov
2014-05-06 11:06 ` [PATCH v5 7/7] Input: pixcir_i2c_ts: Add device tree support Roger Quadros
2014-05-06 11:06 ` Roger Quadros
2014-05-19 5:54 ` Dmitry Torokhov
2014-05-19 7:50 ` Roger Quadros [this message]
2014-05-19 7:50 ` Roger Quadros
2014-05-19 8:27 ` [PATCH v6 " Roger Quadros
2014-05-19 8:27 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5379B7E2.30904@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.