All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	stefanha@redhat.com, kwolf@redhat.com
Subject: Re: [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block device with no medium.
Date: Mon, 19 May 2014 12:00:10 +0400	[thread overview]
Message-ID: <5379BA0A.7080200@msgid.tls.msk.ru> (raw)
In-Reply-To: <1400410205-26152-1-git-send-email-kroosec@gmail.com>

18.05.2014 14:50, Hani Benhabiles wrote:
> The device is exported with erroneous values and can't be read.
> 
> Before the patch:
> $ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0
> Negotiation: ..size = 17592186044415MB
> bs=1024, sz=18446744073709547520 bytes
> 
> $ sudo mount /dev/nbd0 /mnt/tmp/
> mount: block device /dev/nbd0 is write-protected, mounting read-only
> mount: /dev/nbd0: can't read superblock
> 
> After the patch:
> (qemu) nbd_server_add ide0-hd0
> (qemu) nbd_server_add floppy0
> Device 'floppy0' has no medium

I'm not sure this is the right direction.  Maybe we should actually
allow exporting devices with no medium to be able to insert medium
later without re-starting the server?  Especially with -t (persistent).
I dunno.  At least this is the decision which should not be left to
a -trivial tree.

Thank you!

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Hani Benhabiles <kroosec@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	stefanha@redhat.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block device with no medium.
Date: Mon, 19 May 2014 12:00:10 +0400	[thread overview]
Message-ID: <5379BA0A.7080200@msgid.tls.msk.ru> (raw)
In-Reply-To: <1400410205-26152-1-git-send-email-kroosec@gmail.com>

18.05.2014 14:50, Hani Benhabiles wrote:
> The device is exported with erroneous values and can't be read.
> 
> Before the patch:
> $ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0
> Negotiation: ..size = 17592186044415MB
> bs=1024, sz=18446744073709547520 bytes
> 
> $ sudo mount /dev/nbd0 /mnt/tmp/
> mount: block device /dev/nbd0 is write-protected, mounting read-only
> mount: /dev/nbd0: can't read superblock
> 
> After the patch:
> (qemu) nbd_server_add ide0-hd0
> (qemu) nbd_server_add floppy0
> Device 'floppy0' has no medium

I'm not sure this is the right direction.  Maybe we should actually
allow exporting devices with no medium to be able to insert medium
later without re-starting the server?  Especially with -t (persistent).
I dunno.  At least this is the decision which should not be left to
a -trivial tree.

Thank you!

/mjt

  parent reply	other threads:[~2014-05-19  8:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-18 10:50 [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block device with no medium Hani Benhabiles
2014-05-18 10:50 ` [Qemu-devel] " Hani Benhabiles
2014-05-18 10:50 ` [Qemu-trivial] [PATCH 2/2] nbd: Don't validate from and len in NBD_CMD_DISC Hani Benhabiles
2014-05-18 10:50   ` [Qemu-devel] " Hani Benhabiles
2014-05-19 11:05   ` [Qemu-trivial] " Paolo Bonzini
2014-05-19 11:05     ` [Qemu-devel] " Paolo Bonzini
2014-05-19 21:22     ` [Qemu-trivial] " Hani Benhabiles
2014-05-19 21:22       ` [Qemu-devel] " Hani Benhabiles
2014-05-19  8:00 ` Michael Tokarev [this message]
2014-05-19  8:00   ` [Qemu-devel] [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block device with no medium Michael Tokarev
2014-05-19 11:03   ` Paolo Bonzini
2014-05-19 11:03     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379BA0A.7080200@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=kroosec@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.