All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, kvm-ppc@vger.kernel.org
Cc: aik@ozlabs.ru, alex.williamson@redhat.com,
	qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/8] powerpc: Extend syscall ppc_rtas()
Date: Mon, 19 May 2014 12:55:40 +0000	[thread overview]
Message-ID: <5379FF4C.7080202@suse.de> (raw)
In-Reply-To: <1400040722-29608-7-git-send-email-gwshan@linux.vnet.ibm.com>


On 14.05.14 06:12, Gavin Shan wrote:
> Originally, syscall ppc_rtas() can be used to invoke RTAS call from
> user space. Utility "errinjct" is using it to inject various errors
> to the system for testing purpose. The patch intends to extend the
> syscall to support both pSeries and PowerNV platform. With that,
> RTAS and OPAL call can be invoked from user space. In turn, utility
> "errinjct" can be supported on pSeries and PowerNV platform at same
> time.
>
> The original syscall handler ppc_rtas() is renamed to ppc_firmware(),
> which calls ppc_call_rtas() or ppc_call_opal() depending on the
> running platform. The data transported between userland and kerenl is

Please fix your spelling of kernel.

> by "struct rtas_args". It's platform specific on how to use the data.
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

I think the basic idea to maintain the same interface between PAPR and 
OPAL to user space is sound, but this is really Ben's call.


Alex


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, kvm-ppc@vger.kernel.org
Cc: aik@ozlabs.ru, alex.williamson@redhat.com,
	qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 6/8] powerpc: Extend syscall ppc_rtas()
Date: Mon, 19 May 2014 14:55:40 +0200	[thread overview]
Message-ID: <5379FF4C.7080202@suse.de> (raw)
In-Reply-To: <1400040722-29608-7-git-send-email-gwshan@linux.vnet.ibm.com>


On 14.05.14 06:12, Gavin Shan wrote:
> Originally, syscall ppc_rtas() can be used to invoke RTAS call from
> user space. Utility "errinjct" is using it to inject various errors
> to the system for testing purpose. The patch intends to extend the
> syscall to support both pSeries and PowerNV platform. With that,
> RTAS and OPAL call can be invoked from user space. In turn, utility
> "errinjct" can be supported on pSeries and PowerNV platform at same
> time.
>
> The original syscall handler ppc_rtas() is renamed to ppc_firmware(),
> which calls ppc_call_rtas() or ppc_call_opal() depending on the
> running platform. The data transported between userland and kerenl is

Please fix your spelling of kernel.

> by "struct rtas_args". It's platform specific on how to use the data.
>
> Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

I think the basic idea to maintain the same interface between PAPR and 
OPAL to user space is sound, but this is really Ben's call.


Alex

  reply	other threads:[~2014-05-19 12:55 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  4:11 [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Gavin Shan
2014-05-14  4:11 ` Gavin Shan
2014-05-14  4:11 ` [PATCH 1/8] drivers/vfio: Introduce CONFIG_VFIO_EEH Gavin Shan
2014-05-14  4:11   ` Gavin Shan
2014-05-14  4:11 ` [PATCH 2/8] powerpc/eeh: Info to trace passed devices Gavin Shan
2014-05-14  4:11   ` Gavin Shan
2014-05-19 12:46   ` Alexander Graf
2014-05-19 12:46     ` Alexander Graf
2014-05-19 22:37     ` Benjamin Herrenschmidt
2014-05-19 22:37       ` Benjamin Herrenschmidt
2014-05-19 23:54       ` Gavin Shan
2014-05-19 23:54         ` Gavin Shan
2014-05-14  4:11 ` [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-14  4:11   ` Gavin Shan
2014-05-19 12:51   ` Alexander Graf
2014-05-19 12:51     ` Alexander Graf
2014-05-19 23:57     ` Gavin Shan
2014-05-19 23:57       ` Gavin Shan
2014-05-19 22:33   ` Alex Williamson
2014-05-19 22:33     ` Alex Williamson
2014-05-19 22:51     ` Benjamin Herrenschmidt
2014-05-19 22:51       ` Benjamin Herrenschmidt
2014-05-20  0:22     ` Gavin Shan
2014-05-20  0:22       ` Gavin Shan
2014-05-20  0:37       ` Alex Williamson
2014-05-20  0:37         ` Alex Williamson
2014-05-20  8:28         ` Gavin Shan
2014-05-20  8:28           ` Gavin Shan
2014-05-20 10:02           ` Alexander Graf
2014-05-20 10:02             ` Alexander Graf
2014-05-20 10:23             ` Gavin Shan
2014-05-20 10:23               ` Gavin Shan
2014-05-14  4:11 ` [PATCH 4/8] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-14  4:11   ` Gavin Shan
2014-05-14  4:11 ` [PATCH 5/8] powerpc/powernv: Sync OPAL header file with firmware Gavin Shan
2014-05-14  4:11   ` Gavin Shan
2014-05-14  4:12 ` [PATCH 6/8] powerpc: Extend syscall ppc_rtas() Gavin Shan
2014-05-14  4:12   ` Gavin Shan
2014-05-19 12:55   ` Alexander Graf [this message]
2014-05-19 12:55     ` Alexander Graf
2014-05-19 22:38     ` Benjamin Herrenschmidt
2014-05-19 22:38       ` Benjamin Herrenschmidt
2014-05-14  4:12 ` [PATCH 7/8] powerpc/powernv: Implement ppc_call_opal() Gavin Shan
2014-05-14  4:12   ` Gavin Shan
2014-05-19 12:59   ` Alexander Graf
2014-05-19 12:59     ` Alexander Graf
2014-05-14  4:12 ` [PATCH 8/8] powerpc/powernv: Error injection infrastructure Gavin Shan
2014-05-14  4:12   ` Gavin Shan
2014-05-19 13:04   ` Alexander Graf
2014-05-19 13:04     ` Alexander Graf
2014-05-19 22:40     ` Benjamin Herrenschmidt
2014-05-19 22:40       ` Benjamin Herrenschmidt
2014-05-15  6:34 ` [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Mike Qiu
2014-05-15  6:34   ` Mike Qiu
2014-05-15  7:43   ` Gavin Shan
2014-05-15  7:43     ` Gavin Shan
2014-05-19 10:07 ` Gavin Shan
2014-05-19 10:07   ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5379FF4C.7080202@suse.de \
    --to=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=qiudayu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.